Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Data Carrier (New) - The Grand Arcadia #906

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

AjexRose
Copy link
Contributor

@AjexRose AjexRose commented Jan 23, 2024

About the PR

after finally getting off my ass, I decided to finally finish this, this PR adds a new bluespace event known as the "Arcadia Industries Data Carrier" A bluespace event within a fully operational shuttle, filled with lots of loot and entities to fight though. Also includes changes to the Arcadia Industries that were added awhile ago, mainly replacing their blood with oil, and making the Mobile Blaster Units space proof.

Why / Balance

Gives Arcadia Industries more visibility then just a vending machine.
Edit: Also forgot to mention most of the crates are simple random low value spawners.
The high amount of loot within is countered by the fact that the shuttle is simply bursting from the seems with enemies, all ready to pounce at intruders.
The main focus is the R&D loot, which there isnt much attention for as of now in the Frontier.

Technical details

N/A

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    Frontier Station 1_23_2024 2_34_38 PM
    Frontier Station 1_23_2024 2_31_25 PM

Breaking changes

Changelog

🆑 AjexRose

  • add: Added a new bluespace event: The Data Carrier, with lots of loot, enemies, and a small focus on R&D
  • tweak: Arcadia Industries mobs have been slightly reworked to no longer bleed blood.
  • tweak: Fixed the ArcadiaDrobe's vendor sprite

@github-actions github-actions bot added Map-Bluespace Map - Bluespace Event No C# FTL labels Jan 23, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 23, 2024
Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Random Magic Book Spawner (Or at least use the safe one)

Recomendation/Notes:

  • Wizard hardsuit seem compleatly out of place (but also because there was plan to put those in more wizard/alien looking asteroids)
  • Atmos is ehh, started then gone?
  • Floor need decals in my opinion a bit.
  • Does your NPCs has the salvage component? if no they need it so they despawn when the ship despawn.
  • Again make the ship name/annoncement to the default/random.

Resources/Prototypes/_NF/Events/events.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Events/events.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Events/events.yml Outdated Show resolved Hide resolved
Resources/Maps/_NF/Bluespace/DataCarrier.yml Outdated Show resolved Hide resolved
@AjexRose
Copy link
Contributor Author

After testing it via addgamerule and endgamerule, the mobs despawn without the salvage component when the event ends. Either that or they already have it somewhere.

@AjexRose
Copy link
Contributor Author

also the spell book was set to safe, and the wizard hardsuit was replaced by syndicate hardsuit

Copy link
Contributor

@FoxxoTrystan FoxxoTrystan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, tho the Syndicate Hardsuit is an Elite one and seem a bit too easy to get in my opinion but overall il say generally its fine.

Resources/Locale/en-US/_NF/bluespace-events/events.ftl Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the FTL label Jan 23, 2024
@dvir001 dvir001 changed the title The Grand Arcadia Update The Data Carrier (New) - The Grand Arcadia Jan 25, 2024
@AjexRose
Copy link
Contributor Author

AjexRose commented Feb 11, 2024

Updated to have more decals, removed the omega soap, replaced the syndicate hardsuit with AME fuel, switched power from damaged RTGs to regular RTGs, replaced the unused atmos space with a space for portable scrubbers.
Also changed the file name to match current naming standards

@Cheackraze
Copy link
Member

Updated to have more decals, removed the omega soap, replaced the syndicate hardsuit with AME fuel, switched power from damaged RTGs to regular RTGs, replaced the unused atmos space with a space for portable scrubbers. Also changed the file name to match current naming standards

was just looking to do some map reviews and such. Do you have any pictures of the new decaling? it was going to be my only critique of the map itself. Otherwise, I can help update this to the latest build and get this in game, however the vending machine sprite needs fixing desperately as well, if you wouldnt mind taking a look at cleaning that one up.

@Cheackraze
Copy link
Member

just tested it out a few times, the map itself looks nice, especially with the added decals. I'm only a little concerned that it will get powergamed everytime and might in the future re-arrange what items are stored in each of your vault areas. If we could just get that vending machine sprite cleaned up i'd say its good to merge

@AjexRose
Copy link
Contributor Author

AjexRose commented Feb 12, 2024

Just got home from uni, so apologies for not getting back to you sooner

just tested it out a few times, the map itself looks nice, especially with the added decals. I'm only a little concerned that it will get powergamed everytime

Most items are simple fill-in substitutes until I get more faction unique items made.

If we could just get that vending machine sprite cleaned up i'd say its good to merge

I'll start to work on that ASAP

Copy link
Contributor

RSI Diff Bot; head commit 988b52e merging into 7e414c4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/arcadiadrobe.rsi

State Old New Status
normal-unshaded Modified

@AjexRose
Copy link
Contributor Author

vending machine's display sprite has been fixed at last!

@Cheackraze Cheackraze merged commit 5243f59 into new-frontiers-14:master Feb 15, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Feb 15, 2024
@AjexRose AjexRose deleted the Data-Carriers branch February 15, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Bluespace Map - Bluespace Event No C# Sprites Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants