Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crescent (Update) #915

Merged
merged 8 commits into from
Jan 29, 2024
Merged

Crescent (Update) #915

merged 8 commits into from
Jan 29, 2024

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Jan 24, 2024 •
edited
Loading

About the PR

Updating KC Crescent to current mapping standards (not much needed to changed):

  • Colored pipes that missed color.
  • Removed loose encryption keys.
  • Replaced custom gun safe in mercenary room with T2 Gun Safe Spawner.
  • Replaced some computer consoles with tabletop variants.
  • Added Vacuum Markers to exposed to space tiles.
  • Enabled Pilot Job.
  • Moved ship.yml to Maps/_NF/Shuttles/

Why / Balance

New mapping standards.

Media

  • Not needed.

Changelog
🆑 erhardsteinhauer

  • tweak: Updated KC Crescent to current mapping standards.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Jan 24, 2024
@ErhardSteinhauer
Copy link
Contributor Author

Ship owner: @Kesiath
(Just tagging you to make sure you're aware there's suggested changes for you ship.)

@ErhardSteinhauer ErhardSteinhauer changed the title NC Crescent Update KC Crescent Update Jan 24, 2024
TsjipTsjip
TsjipTsjip suggested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@TsjipTsjip TsjipTsjip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update .github/mapchecker/whitelist.yml and remove Crescen'ts entry entirely. We fixed these entries in VC, file just needs to be updated.

@TsjipTsjip TsjipTsjip mentioned this pull request Jan 24, 2024
Open
69 tasks
TsjipTsjip
TsjipTsjip approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@TsjipTsjip TsjipTsjip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mapchecker is happy, and so am I!

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 24, 2024
@dvir001 dvir001 changed the title KC Crescent Update Crescent (Update) Jan 25, 2024
@github-actions github-actions bot added C# Merge Conflict This PR has conflicts that prevent merging and removed No C# labels Jan 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jan 29, 2024
@dvir001 dvir001 self-requested a review January 29, 2024 21:57
@dvir001 dvir001 merged commit f60f138 into new-frontiers-14:master Jan 29, 2024
10 of 11 checks passed
FrontierATC added a commit that referenced this pull request Jan 29, 2024
@FrontierATC
Automatic Changelog (#915)
4004121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TsjipTsjip TsjipTsjip TsjipTsjip approved these changes

@dvir001 dvir001 dvir001 approved these changes

@MagnusCrowe MagnusCrowe Awaiting requested review from MagnusCrowe

Assignees
No one assigned
Labels
C# Map-Shuttle Map - Shuttle Status: Needs Review This PR is awaiting reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErhardSteinhauer @TsjipTsjip @dvir001