Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plant box #921

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Plant box #921

merged 7 commits into from
Feb 19, 2024

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 24, 2024

About the PR

This came to me in a dream,
As I was sleeping, the egg man showed up in his egg domain.

His eyes were EGG, his mouth was EGG.
With the sound of 1000 eggs cracking he said to me, EGG.
"W..what?"
His voiced echoed louder, EGG.

Then and there I knew, the Egg man was coming, and he is coming to collect his eggs.

Here I am waking up, shaken in eldritch fear, knowing my time is short in this world, for the egg man is coming and I most pay his toll

Egg is life, egg is love.

Why / Balance

Remove some entity lags by giving players actual big storage for plants

Technical details

.yml

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame,

Breaking changes

N/A

Changelog
🆑 dvir01,gentlebutter

  • add: Added the plant box storage, you can now buy a big storage for plants from cargo.

Copy link
Contributor

github-actions bot commented Jan 24, 2024

RSI Diff Bot; head commit 7a75747 merging into fb086e7
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Storage/plantbox.rsi

State Old New Status
plantbox-top Added
plantbox Added

Edit: diff updated after 7a75747

@github-actions github-actions bot added Merge Conflict This PR has conflicts that prevent merging labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

1 similar comment
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Feb 10, 2024
@dvir001 dvir001 changed the title Plant box & Plant bag of holding Plant box Feb 15, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Feb 15, 2024

This PR was changed to only contain the plant box for now

@dvir001 dvir001 marked this pull request as ready for review February 15, 2024 16:07
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Feb 15, 2024
@dvir001
Copy link
Contributor Author

dvir001 commented Feb 19, 2024

Fixed

@Cheackraze Cheackraze merged commit fead3cb into new-frontiers-14:master Feb 19, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants