Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cyborg Charging Station & Cell Charger Machine Boards to Frontier CircuitVend #922

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

wafehling
Copy link
Contributor

About the PR

I added two products to the CirctuitVend on Frontier Station, the Cyborg Recharging Station Machine Board and the Cell Recharger Machine Board

This is my first PR for anything ever, please be merciful.

Why / Balance

Being a Cyborg on Frontier is difficult.

To be even moderately useful to station crew, you need specialized modules. You can only get them from scientists who've researched them and have the available materials and machines to make them, who are usually off-station, but leaving the station and working with crew on ships without a charger (especially with your default battery) is very difficult.

Running out of power and hunting around for a charger and juggling power cells is not fun or good gameplay, and right now outside of autoclaving the boards, there's no reliable source beyond the single charger in Frontier maint tunnels.

It's as if there was a single food vending machine in all of frontier hidden in a corner, and someone had to hand-feed you anything you brought off the station.

These boards will add an easier way for cyborgs to work with the station crew, live their life, and get where they need to be without having to constantly fret about power levels.

Technical details

Nothing complicated. Upped the price a little (They're still worth less than their mats when sold, no worries there) and added their entries to the vendor list.

Media

image

  • [X ] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Shouldn't cause any problems, nothing fragile has been changed.

Changelog
8 Cyborg Recharging Station Machine Boards and 8 Cell Recharger Machine Boards now available at Frontier Station's CirctuitVend. For the adventurous cyborg.

@dvir001
Copy link
Contributor

dvir001 commented Jan 26, 2024

Do not change the static price on the board this is off setting the market by adding another boards that has mats to price ratio issue.

We probably need to off set the vending machine itself at that point.

@dvir001
Copy link
Contributor

dvir001 commented Jan 27, 2024

Updated the vend machine to mod 25
Updated StaticPrice on boards to fix pricing, some boards price didnt change, some went up a bit:

image

This should be fine now.

@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 27, 2024
@Cheackraze Cheackraze merged commit cf8e3e5 into new-frontiers-14:master Jan 29, 2024
11 of 12 checks passed
@wafehling wafehling deleted the BorgAndCellVendable branch January 30, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants