Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Valentine #933

Closed
wants to merge 4 commits into from
Closed

Add the Valentine #933

wants to merge 4 commits into from

Conversation

VividPups
Copy link
Contributor

@VividPups VividPups commented Jan 28, 2024

About the PR

Adds the Valentine Pistol

Why / Balance

The original idea of this gun was to have it added to the T2 gun safe to help balance out the changes of getting the other guns than just a shotgun however, I do not know how to add that to that loot pool so, I also seem to notice that there isn't a lot of other Legal firearms on Frontier/SS14 within itself. So I am attempting to make More and different varieties of the current guns to add more Legal weapons and eventually illegal ones) at the same time, I want to make more references to beloved game franchises and irl guns that we love. This is to help expand on the current quite small Weapon list. Help give a lot more options when mapping

This gun is based on the Mk58
Firing rate of 5 with a magazine size of 10 + 1
So PR will add the Valentine pistol
"There is S.T.A.R embedded inside the wooden and textured pistol grip, with a Silver Barrel. Chamber in .35 auto."
Firing rate of 2.5
Magazine size 10 + 1
This is Jill Valentine's Variation of the pistol

I have tested it with all 35 auto ammo and seems to work
Also a NonLethal Verison of the gun

Technical details

adds the Pistol.yml file

Media

image
image
image
image

  • I have added screenshots/videos to this PR showcasing its changes in-game

Changelog

Copy link
Contributor

github-actions bot commented Jan 28, 2024

RSI Diff Bot; head commit fe38aca merging into dbc7121
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Weapons/Valentine.rsi

State Old New Status
base Added
bolt-open Added
equipped-BELT Added
icon Added
inhand-left Added
inhand-right Added
mag-0 Added

Edit: diff updated after fe38aca

@dvir001
Copy link
Contributor

dvir001 commented Jan 28, 2024

RSI Broken

@dvir001 dvir001 added the Status: Awaiting Changes This PR has changes that need to be made before merging label Jan 28, 2024
@VividPups
Copy link
Contributor Author

How is it broken?

@dvir001
Copy link
Contributor

dvir001 commented Jan 28, 2024

How is it broken?

RSI Validator / Validate RSIs (pull_request)

@VividPups
Copy link
Contributor Author

I saw that, however, I do not know how to fix it. But, by reading it. It sounds like it's something with the Copyright?

@TsjipTsjip
Copy link
Contributor

I saw that, however, I do not know how to fix it. But, by reading it. It sounds like it's something with the Copyright?

I think the test checks if you used a valid license type. Your license given is not one of the ones that's allowed, and you should check the output for which one is most appropriate and aligns most closely to what you have in mind.

@VividPups
Copy link
Contributor Author

I was thinking that also, Hopefully this is the fix for it

@VividPups
Copy link
Contributor Author

I also realize that there isn't an actual way to obtain The Valentine. I figure for a trial It would be added to the Liberty station. until more POI/Events/Dungeons. This might help let people know about the gun

@VividPups
Copy link
Contributor Author

The RSI has been fix

@dvir001
Copy link
Contributor

dvir001 commented Jan 29, 2024

Still need to inspect this for balance, adding @MagnusCrowe on it also.

@github-actions github-actions bot added Status: Needs Review This PR is awaiting reviews and removed Status: Awaiting Changes This PR has changes that need to be made before merging labels Jan 29, 2024
@VividPups VividPups closed this by deleting the head repository Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants