Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sparrow (Update) #955

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Sparrow (Update) #955

merged 2 commits into from
Feb 2, 2024

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Jan 30, 2024 •
edited
Loading

About the PR

Updating NR Sparrow to current mapping standards:

  • Wiring rework.
  • Atmos rework.
  • Replaced some consoles with tabletop variants.
  • Scrapped the atmosia, replaced it with engineering room.
  • Added Vacuum Markers to exposed to space tiles.
  • Moved ship.yml to Maps/_NF/Shuttles/
  • Updated mapchecker whitelist.

Why / Balance

New mapping standards, never ever seen atmosia used on this ship (might be wrong, don't have any statistics to support this claim).

Media

2024-1-30_18 02 58

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Changelog
🆑 erhardsteinhauer

  • tweak: Updated (and slightly reworked) NR Sparrow to current mapping standards.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle No C# labels Jan 30, 2024
@TsjipTsjip TsjipTsjip mentioned this pull request Jan 30, 2024
Open
69 tasks
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Jan 30, 2024
MagnusCrowe
MagnusCrowe previously requested changes Feb 2, 2024
View reviewed changes
Resources/Prototypes/_NF/Shipyard/sparrow.yml Outdated Show resolved Hide resolved
@MagnusCrowe MagnusCrowe added the Status: Awaiting Changes This PR has changes that need to be made before merging label Feb 2, 2024
@github-actions github-actions bot removed the Status: Awaiting Changes This PR has changes that need to be made before merging label Feb 2, 2024
@dvir001 dvir001 self-requested a review February 2, 2024 23:09
dvir001
dvir001 approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working.

@dvir001 dvir001 merged commit fb3fd8b into new-frontiers-14:master Feb 2, 2024
12 of 13 checks passed
FrontierATC added a commit that referenced this pull request Feb 2, 2024
@FrontierATC
Automatic Changelog (#955)
c572e62
@ThatOneGoblin25 ThatOneGoblin25 mentioned this pull request Feb 14, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvir001 dvir001 dvir001 approved these changes

@MagnusCrowe MagnusCrowe Awaiting requested review from MagnusCrowe

Assignees
No one assigned
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ErhardSteinhauer @dvir001 @MagnusCrowe