Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messenger Bags (ported from tgstation) #962

Merged
merged 26 commits into from
Feb 9, 2024

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Jan 31, 2024

About the PR

Port of messenger bags from TG Station (original sprites were made by Zydras) with addition of missing job/department specific or high-tech messenger bags by erhardsteinhauer. Stat-wise messenger bags are exactly the same as satchels/backpacks. New bags are distributed among corresponding vendomats. Messenger bag of holding is researchable and can be crafted. Thanks to dvir001 messenger bags are available as starting loadout.

Added bags:

  • Atmospherics tech messenger bag (custom made).
  • Brigmedic messenger bag in new NFSD colors (palette made by GhostPrince).
  • Captain messenger bag.
  • Cargo messenger bag (custom made).
  • Chemistry messenger bag.
  • Clown messenger bag.
  • Engineering messenger bag.
  • Genetics messenger bag.
  • Hydroponics messenger bag.
  • Medical messenger bag.
  • Mercenary messenger bag (custom made).
  • Grey messenger bag.
  • Pilot messenger bag (custom made).
  • Salvage messenger bag.
  • Science messenger bag.
  • Security messenger bag in new NFSD colors (palette made by GhostPrince).
  • Virology messenger bag.
  • Syndicate messenger bag (custom made).
  • Mailperson messenger bag (custom made).
  • Janitor messenger bag (custom made).
  • Mime messenger bag (custom made).
  • Messenger bag of holding (custom made).

To do:

  • [ ] Roboticist messenger bag. I'll do it as soon as someone adds Surgery and Prosthetics. So probably next week or something.
  • [ ] Custom genetics messenger bag (right now looks identical to medical). I'll do it as soon as someone adds Genetics. So probably right after surgery'n'stuff or something.
  • Mime messenger bag? Mimes aren't real.
  • Other bags I forgot about?

Why / Balance

Looks cool.

Media

image

  • I have added screenshots/videos to this PR showcasing its changes ingame.

Changelog
🆑 erhardsteinhauer, dvir001 (cs magic), original sprites by Zydras

  • add: Added a variety of messenger bags, check outfit vendomats near you. Thanks to dvir001 messenger bags are available as starting loadout.

Copy link
Contributor

github-actions bot commented Jan 31, 2024

RSI Diff Bot; head commit 0ce41a1 merging into 6c4e410
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Clothing/Back/Messenger/atmospherics.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/brigmedic.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/captain.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/cargo.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/chemistry.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/clown.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/engineering.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/genetics.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/holding.rsi

State Old New Status
broken-inhand-left Added
broken-inhand-right Added
broken Added
equipped-BACKPACK Added
icon-unlit Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/hydroponics.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/janitor.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/mailman.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/medical.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/mercenary.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/messenger.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/mime.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/pilot.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/salvage.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/science.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/security.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/syndicate.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Clothing/Back/Messenger/virology.rsi

State Old New Status
equipped-BACKPACK Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after 0ce41a1

@dvir001
Copy link
Contributor

dvir001 commented Jan 31, 2024

Need me to add it as a spawn option?

@ErhardSteinhauer
Copy link
Contributor Author

Need me to add it as a spawn option?

Would be neat

@ErhardSteinhauer ErhardSteinhauer marked this pull request as ready for review January 31, 2024 23:14
@dvir001
Copy link
Contributor

dvir001 commented Jan 31, 2024

Need me to add it as a spawn option?

Would be neat

Done

@ErhardSteinhauer ErhardSteinhauer changed the title Messenger Bags (tgstation port) Messenger Bags (ported from tgstation) Feb 1, 2024
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Feb 1, 2024
@dvir001
Copy link
Contributor

dvir001 commented Feb 1, 2024

Mimes aren't real?
Big sad

Copy link
Contributor

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Merge Conflict This PR has conflicts that prevent merging labels Feb 8, 2024
Copy link
Contributor

github-actions bot commented Feb 8, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Cheackraze
Copy link
Member

Bummer, I liked a lot of these!

@ErhardSteinhauer
Copy link
Contributor Author

Bummer, I liked a lot of these!

I'm just updating it. Will reopen soon.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Feb 8, 2024
@ErhardSteinhauer ErhardSteinhauer marked this pull request as draft February 8, 2024 22:32
@ErhardSteinhauer ErhardSteinhauer marked this pull request as ready for review February 8, 2024 23:30
@ErhardSteinhauer
Copy link
Contributor Author

I think it should be ready for review now.

Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great.

@dvir001 dvir001 merged commit 79e489e into new-frontiers-14:master Feb 9, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants