Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SV Rocket #976

Closed
wants to merge 16 commits into from
Closed

SV Rocket #976

wants to merge 16 commits into from

Conversation

Lokey82
Copy link
Contributor

@Lokey82 Lokey82 commented Feb 4, 2024

About the PR

This pull request adds my latest creation: The SV Rocket, a small, incredibly cheap, and questionably safe ship that I originally built as a joke hence the name being a play on words referencing the fact that the walls of this ship are made of rock.
With only a price listed of 7000 spessos this makes a great ship for those who find themselves in financial trouble.
Ironically enough as well, this new ship is also built for a variety of tasks (such as smuggling if you have a name hiding IFF, SSH) such as mining, even coming pre-equipped with very cheap and basic mining supplies (A pickaxe, emergency EVA, and mag boots)
A goal I had for creating this ship was also making it if not the cheapest, one of the cheapest ships on the market which meant of course certain budget cuts had to be made to ensure this ship would be as affordable as it is, some of these include: Substituting a gravity generator with mag boots, the generator powering the APC directly rather than using a SMES and substation, Oxygen supply is a single oxygen canister, The lighting is provided by a floodlight (cell charger included), All windows are replaced with inflatable barriers, and it only starts with 5 sheets of plasma for the generator.
All these budget cuts not only make it an incredibly cheap yet still decent choice of ship but also enhances the feel of the ship's shoddiness as it is not only an SV, it is a little hard to imagine a luxury ship with every necessity met crammed into a tiny asteroid shaped pile held together by one's sheer will not to use a pickaxe on it.

Ultimately this pile of rock that I dare call a ship despite being created as a joke I believe should make a wonderful addition to the game for those who are looking for something cheap yet still somewhat reliable. (or a flying asteroid that can easily pass as a real one with the right IFF console.)

Why / Balance

As mentioned above, this ship will not only be great for those looking for something incredibly cheap but also accidentally made perfect for smuggling as it is an incredibly small ship shaped like an asteroid and I feel with the use of a basic IFF console it can possibly pass as a asteroid as well at first glance.

Technical details

The only code used in this project was the shipyard file which I seriously hope works.

Media

Ingame
Ingame view (FOV off)

Mapper
Mapping view

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: One of NanoTrasen's ship engineers thought it would be funny if they tried to sell the crew a rock, So we now introduce the all new SV Rocket! (pun intended)

@Lokey82
Copy link
Contributor Author

Lokey82 commented Feb 4, 2024

By the way: I understand the docks are kitty-cornered, I do have a fix planned that will release tomorrow.

Sligtly redesigned the ship's shape
Fixed kitty-cornering in the docks
Updated PR media
Resources/Prototypes/_NF/Shipyard/rocket.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Shipyard/rocket.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Shipyard/rocket.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Shipyard/rocket.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Shipyard/rocket.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Shipyard/rocket.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Shipyard/rocket.yml Outdated Show resolved Hide resolved
Resources/Prototypes/_NF/Shipyard/rocket.yml Outdated Show resolved Hide resolved
Resources/Maps/Shuttles/rocket.yml Show resolved Hide resolved
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Feb 4, 2024
Fixed shipyard file
Synced rocket branch with master
Moved rocket.yml to /Maps/_NF/Shuttles/rocket.yml
(Thank you Dvir for being patient with me, I am still very inexperienced with github)
@Lokey82
Copy link
Contributor Author

Lokey82 commented Feb 6, 2024

It appears that VS is having a bit of trouble pushing my latest commit with all the filepath changes.
Expect a fix and the commit to be pushed hopefully tomorrow.

Lokey82 and others added 5 commits February 6, 2024 19:58
Synced rocket branch with master
Moved rocket.yml to /Maps/_NF/Shuttles/rocket.yml
(Thank you for being patient with me, I am still very inexperienced with github)
Removed extra rocket.yml from /maps/shuttles
@github-actions github-actions bot removed the YML label Feb 7, 2024
@Lokey82
Copy link
Contributor Author

Lokey82 commented Feb 7, 2024

After lots of messing around, I finally got it working again! I hope I didn't make too big a mess doing so.

@dvir001
Copy link
Contributor

dvir001 commented Feb 7, 2024

image
Remove the extra copy of the file, im moving this to draft till its ready for the actual ship review.

@dvir001 dvir001 marked this pull request as draft February 7, 2024 14:28
Got rid of the extra ship file (For real this time)
@Lokey82
Copy link
Contributor Author

Lokey82 commented Feb 9, 2024

image Remove the extra copy of the file, im moving this to draft till its ready for the actual ship review.

Alrighty then! Just let me know what needs to get done and hopefully, it will be back on the review list soon!

Lokey82 and others added 4 commits March 9, 2024 12:25
- Added 2 stage airlock
- Re-arranged most of the ship
- Added waste line
- Replaced oxy can for air can
- Updated PR media

(This is hopefully the last fix before I take it out of draft phase, of course since I am a newer mapper, I will be consulting the mapping discord to help identify potential issues.)
Rocket fix 007:
Added 2-stage airlock
Re-arranged most of the ship
Added waste line
Replaced oxy can for air can
Updated PR media
(This is hopefully the last fix before I take it out of the draft phase, of course since I am a newer mapper, I will be consulting the mapping discord to help identify potential issues.)
- Added BecomeStation component
- Fixed thruster power issue
- Updated price (7000->7500)
- Added defibrilator
- Added fire extinguisher
- Unanchored generator and added wrench to fix power network bug where the ship would stay unpowered unless generator was re-anchored.
- Replaced airlocks with easy-pry airlocks to account for ship starting unpowered

(Removing ship from draft phase, Wish me luck!)
@Lokey82 Lokey82 marked this pull request as ready for review March 9, 2024 23:10
@Lokey82
Copy link
Contributor Author

Lokey82 commented Mar 9, 2024

Well, I made some changes, Hopefully, they are satisfactory!

@Lokey82 Lokey82 requested a review from dvir001 March 9, 2024 23:11
@MagnusCrowe
Copy link
Contributor

I don't think this ship should be added. It's a trap of a ship for players who have very little money. If checkraze disagrees, he can approve it personally.

@Cheackraze
Copy link
Member

I don't think this ship should be added. It's a trap of a ship for players who have very little money. If checkraze disagrees, he can approve it personally.

it can go in the scrapyard. We should put out a call for someone to make a proper scrapyard POI and move the terminal out there, or maybe we can put it on Tinnia's or something.

@Cheackraze
Copy link
Member

Looks like you have a leftover file in there as well. Clean that up and put it in the scrapyard and then I will merge it

@Lokey82
Copy link
Contributor Author

Lokey82 commented Mar 14, 2024

Looks like you have a leftover file in there as well. Clean that up and put it in the scrapyard and then I will merge it

I am happy to hear that my ship might get in, it was indeed intended to be a scrapyard ship as per the fleet designation SV, Sorry about the extra file, that has been plaguing this PR for a little while but I will see if I can finally get rid of it.

Finally got rid of that extra file (Hopefully)
@github-actions github-actions bot added the YML label Mar 14, 2024
@dvir001
Copy link
Contributor

dvir001 commented Apr 8, 2024

Ill be honest here,
As it stands, I think we have more than a fair share of LRP looking ships in the scrapyard, what started as a place to added retired or scraped ships is now a meme shipyard.

Who the hell will sell this in a mass production run? who the hell will buy this as an actual working ship?

This is like next level of scrap, I don't think this should be added at all.

@MagnusCrowe
Copy link
Contributor

I don't think this ship is a good fit for the server.
I gave you feedback on discord on how to make it something that we would want to have on the server but it seems the advice was ignored.

I am going to close this PR for now. If we decide that we want to include it at a later date, we can open the PR again.

@MagnusCrowe MagnusCrowe closed this Apr 8, 2024
@Lokey82 Lokey82 deleted the Rocket branch November 10, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Map-Shuttle Map - Shuttle No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants