Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crime Assist pda program (DeltaV) #993

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Feb 9, 2024

About the PR

Add a Crime Assist program, which helps NFSD and Lawyer players determine what crime was committed without having to have a wiki open.

Why / Balance

For many players, evidently, reading up on Space Law is an insurmountable obstacle, and as a result they have trouble identifying what is and isn't a crime. For this reason, a PDA program that gives a basic way to see what sort of crime was committed may help.

Technical details

The PDA program is fairly simple. It has a ew buttons (Start, Home, Yes, No) which are visible/invisible depending on the program's State. This State also determines which Localization string is displayed.

The laws are based on DeltaV and will need changes done for Frontier to be fully working.

Media

DeltaV-Station/Delta-v#464

Breaking changes

N/A

Changelog
🆑 Master2112

  • add: Added the Crime Assist program to Security and Lawyer PDA's, to help identify a crime with a simple yes/no question tree.

Timfa2112 and others added 11 commits December 31, 2023 23:39
* Completely untested first commit

* Get basic program flow working

* Add Innocent

* Add Fancy Rich Text

* Icon

Thanks, IcedQuinn!

* Add Cartridge icons

* New image from IcedQuinn

* Add explanation on what a Sophont is, to be automatically appended to any text referencing a Sophont later on

* Convert tabs to spaces

* remove [bold] tags from loc

* Make text bold again

* Alter formatting, reduce text length for sophont explanation to fit it on the screen

* Update Resources/Locale/en-US/deltav/cartridge-loader/cartridges.ftl

Co-authored-by: Colin-Tel <[email protected]>
Signed-off-by: Tim Falken <[email protected]>

* Add program to more PDA's

* Add a tip about the app

* Recreate flow in yaml

todo: actually load and use this yaml

* Remove the old state machine, and add configurable yaml prototypes to define pages

* Move page to its own file

---------

Signed-off-by: Tim Falken <[email protected]>
Co-authored-by: Colin-Tel <[email protected]>
* Create CrimeassistTest.cs

* Fix invalid crimeasssist entries

* Clean up test code
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Feb 9, 2024
@dvir001 dvir001 added Status: Awaiting Changes This PR has changes that need to be made before merging Status: DO NOT MERGE and removed Status: Needs Review This PR is awaiting reviews labels Feb 9, 2024
Copy link
Contributor

github-actions bot commented Feb 9, 2024

RSI Diff Bot; head commit 9c0782e merging into 001d78e
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Icons/cri.rsi

State Old New Status
cri Added

Edit: diff updated after 9c0782e

Copy link
Member

@Cheackraze Cheackraze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that crimeassistflow.yml scares me, and I assume this still needs to be all rewritten for our space law. My only real concern (other than trying to comprehend the crimeassistflow.yml) is that its another location in the codebase that we need to remember to update any time theres a change in space law.

@DebugOk
Copy link
Contributor

DebugOk commented Feb 19, 2024

that crimeassistflow.yml scares me, and I assume this still needs to be all rewritten for our space law. My only real concern (other than trying to comprehend the crimeassistflow.yml) is that its another location in the codebase that we need to remember to update any time theres a change in space law.

Luckily theres a test written for it that makes it a lot harder to break stuff https://github.com/DeltaV-Station/Delta-v/blob/594f56445829c1a95e2a251b785a7ffb63fc874a/Content.IntegrationTests/Tests/DeltaV/CrimeassistTest.cs

It wont auto update, but you cant easily have invalid entries

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Jul 10, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jul 10, 2024
@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Aug 11, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Aug 12, 2024
@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Aug 18, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# FTL Sprites Status: Awaiting Changes This PR has changes that need to be made before merging Status: DO NOT MERGE UI YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants