Update dependencies (including web-ext) #2145
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcustyphoon
force-pushed
the
update-dependencies-2
branch
from
958aded
to
a242690
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates npm dependencies and github actions dependencies, clearing up all security warnings.
Requires at least node 16 (for
web-extto run); it actually has dependencies that request node 18 but I don't see any problems running scripts on 16.Warning: this updates web-ext to v8, which per https://extensionworkshop.com/documentation/develop/web-ext-command-reference/ requires some command changes. I did not test
web-ext sign. #2142 is a PR without this bump.Also, while I did run
gulp server(in node 14-20), I never set up local development and so I have no idea if it actually works with this PR. I have no clue if anyone else has one set up, frankly, but ideally one should, you know, test that at all.