Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of tests related to the contamination properties #188

Closed
3 tasks done
prisma34 opened this issue Jul 18, 2024 · 2 comments
Closed
3 tasks done

Implementation of tests related to the contamination properties #188

prisma34 opened this issue Jul 18, 2024 · 2 comments
Assignees
@prisma34
Labels
enhancement New feature or request
Milestone
Release of v3.0.0

Comments

@prisma34
Copy link
Collaborator

prisma34 commented Jul 18, 2024 •
edited
Loading

Implement tests for initialization and boundary values verification in the tests package. Also reference data are to be added in file properties_bounds.json.

  • Tests for contamination properties in pure lead.

  • Tests for contamination properties in pure bismuth.

  • Tests for contamination properties in LBE.

This issue is related to what implemented for managing issue #183.
@lelaus lelaus added the enhancement New feature or request label Jul 18, 2024
@lelaus lelaus added this to the Release of v3.0.0 milestone Jul 18, 2024
This was referenced Jul 18, 2024
Closed
Closed
Closed
prisma34 pushed a commit that referenced this issue Jul 22, 2024
Merging branches to adress issue #188
234f557
prisma34 pushed a commit that referenced this issue Jul 22, 2024
Merging lbe branch to adress issue #188
66c32b5
prisma34 pushed a commit that referenced this issue Aug 12, 2024
[188_contamination_tests_in_common], issue #188, Implementation of pr…
aa78565 
…operty bounds, impplementation of LeadContaminationTester, BismuthContaminationTester and LBEContaminationTester. Samll modifications of heavy liquid metal contamination modules to fit with the tests. No need of inisialization_helper methods.
lelaus added a commit that referenced this issue Aug 28, 2024
@lelaus
[188_contamination_tests_in_common], issue #188, Little mod to check …
20d6dd1 
…automatic tests
lelaus added a commit that referenced this issue Aug 28, 2024
@lelaus
[188_contamination_tests_in_common], issue #188, Updated reference va…
4b8d7d8 
…lues file following the local update of numpy according to the version used in github platform
@lelaus
Copy link
Collaborator

lelaus commented Aug 29, 2024

Following the update of the numpy library, in 4b8d7d8 a few reference values that are used for test purposes have been changed.

This was referenced Aug 29, 2024
Merged
Merged
Merged
@lelaus
Copy link
Collaborator

lelaus commented Aug 30, 2024

The tests related to the contaminant properties implemented for lead, bismuth and LBE have been added to lbh15.

No need to change the doc.

@lelaus lelaus closed this as completed Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prisma34 prisma34

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release of v3.0.0
Development

No branches or pull requests
2 participants
@prisma34 @lelaus