Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace plugin name with dynamic value from container #10

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

circlecube
Copy link
Member

Proposed changes

With the final round of copy edits a hard coded bluehost string slipped through. This uses the same sprintf method to replace the plugin name with the id from the container.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Mar 20, 2024
@circlecube circlecube merged commit c8b09a2 into main Mar 20, 2024
5 of 6 checks passed
@circlecube circlecube deleted the fix/plugin-name-typo branch March 20, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants