Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require the newfold-features script and only display enabled features #16

Merged

Conversation

circlecube
Copy link
Member

Proposed changes

This updates the "Are you sure" cards to display only if that feature is enabled.

If the site doesn't have a feature enabled for example, we shouldn't show that as a plugin feature to consider when deactivating (we already do this with the WooCommerce Tools card).

We should also add some more cards in case all the current ones do not display.

See: PRESS0-1417

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube merged commit a01eb3f into main Jun 5, 2024
1 of 6 checks passed
@circlecube circlecube deleted the update/check-features-for-are-you-sure-card-conditions branch June 5, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants