Add an "Are you sure" interstitial #9
Conversation
static/js/deactivation-survey.js
Outdated
| <p class="nfd-deactivation__content-subtitle">This plugin is powers important features on your site. These will no longer be available if you deactivate the plugin.</p> | ||
| </div> | ||
| <div class="nfd-deactivation__body"> | ||
| <div class="nfd-deactivation__cards"> | ||
| <div class="nfd-deactivation__card">Hosting integrations</div> | ||
| <div class="nfd-deactivation__card">Performance Improvements</div> | ||
| <div class="nfd-deactivation__card">Staging Site Support</div> | ||
| <div class="nfd-deactivation__card">Wonder Blocks</div> | ||
| <div class="nfd-deactivation__card">Integrated AI Help Center</div> |
There was a problem hiding this comment.
Is it possible that we add the copy to the runtimeData.strings to match the rest of the module copy?
There was a problem hiding this comment.
Added all content to the runtime data strings and set it up for overrides in the container from plugins.
static/js/deactivation-survey.js
Outdated
| <div class="nfd-deactivation__footer"><div class="nfd-deactivation__footer-content"> | ||
| <div class="nfd-deactivation-survey__content-actions"> | ||
| <div class="nfd-deactivation__helptext" "style="text-align:left"> | ||
| <p><b>Need Help?</b> Learn more about <a href="#" target="_blank" nfd-deactivation-survey-destroy>the features of this plugin</a>, check the <a href="#">help center</a>, or <a href="#">contact support</a>.</p> |
There was a problem hiding this comment.
Same here with the copy, and the href doesn't seem to be going anywhere.
There was a problem hiding this comment.
Added placeholder urls, and will likely rework this section once we have copy.
static/js/deactivation-survey.js
Outdated
| </button> | ||
| <button type="button" nfd-deactivation-survey-next | ||
| class="button button-seconday" | ||
| aria-label="${ runtimeData.strings.submitAriaLabel }"> |
|
Another thing to add to the code review, I'm not super keen on the design, few things stood out to me:
|
|
Yes @wpalani - I should have marked this as "not ready" since I'm waiting on some final copy. I am still planning on updating the strings to be pulled in from the runtime data and exposing that so plugins can override it. And other things like making sure the link goes somewhere )if we even want a link there). As content finalizes too I am planning another round of style tweaks. Loosely basing the design off the one in JP. |
cards have title and description text and a conditional to be evaluated determining visibility of the card.
|
New preview screenshots:
|
Proposed changes
This adds an "Are you sure?" interstitial before showing the deactivation survey.
I added styles - inspired by similar interstitials and updated the survey styles for consistency.
This is still waiting on better/final copy/content from @chrisdavidmiles but the code is set up now, I'll add some screenshots for preview.
TODO:
Type of Change
Checklist
Further comments