Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update naming conventions #303

Merged
merged 6 commits into from
Jul 10, 2024
Merged

update naming conventions #303

merged 6 commits into from
Jul 10, 2024

Conversation

manikantakailasa
Copy link
Contributor

must replace values

site.url to siteUrl
site.title to siteTitle
admin_url to adminUrl
base_url to homeUrl
remove the sdk property and let its contents live at the top level

Jira - https://jira.newfold.com/browse/PRESS0-1194

@ramyakrishnai
Copy link
Contributor

use add_filter( 'newfold_runtime', array( $this, 'add_to_runtime' ) ); in ecommerce.php

ramyakrishnai
ramyakrishnai previously approved these changes Jul 2, 2024
@aratidgr8
Copy link
Contributor

@manikantakailasa Is this change QA tested for all dependent newfold-labs modules, without this confirmation we should not merge this branch

@aratidgr8 aratidgr8 merged commit 9e85f65 into trunk Jul 10, 2024
3 of 5 checks passed
@aratidgr8 aratidgr8 deleted the PRESS0-1194 branch July 10, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants