Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change the option name according to newfold standards #312

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

ramyakrishnai
Copy link
Contributor

@ramyakrishnai ramyakrishnai commented May 17, 2024

Proposed changes

Change the option name according to newfold standards from showMigrationSteps to nfd_show_migration_steps

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ramyakrishnai ramyakrishnai marked this pull request as draft May 17, 2024 09:53
@ramyakrishnai
Copy link
Contributor Author

This needs to go live with same version of BH when newfold-labs/wp-module-migration#23 went live

@ramyakrishnai ramyakrishnai marked this pull request as ready for review May 27, 2024 13:04
@sangeetha-nayak
Copy link
Contributor

Could you please update the same in one of cypress file as well? Please see the usage in trunk here

@ramyakrishnai
Copy link
Contributor Author

Could you please update the same in one of cypress file as well? Please see the usage in trunk here

Done @sangeetha-nayak.
Can you please confirm if there is any where else that I need to change.

Thanks!

mamatharao05
mamatharao05 previously approved these changes Jun 12, 2024
@aratidgr8 aratidgr8 merged commit 1a0dbcd into trunk Jun 26, 2024
4 of 7 checks passed
@aratidgr8 aratidgr8 deleted the update/changeOptionName branch June 26, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the option name according to newfold standards from showMigrationSteps to nfd_show_migration_steps
4 participants