Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration updates in the home page #321

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Migration updates in the home page #321

merged 10 commits into from
Jul 10, 2024

Conversation

krsomayagi
Copy link
Contributor

Proposed changes

Press0-1272 - Post Migration info in the home page is captured as part of the cypress script.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

} );

it( 'Verify if One last thing to do... section shows', () => {
cy.contains('Finish this last step so your migrated site is ready for visitors.')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use text validations. validate other identifiers instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some wait time as well

@sangeetha-nayak sangeetha-nayak self-requested a review June 26, 2024 09:43
Copy link
Contributor

@sangeetha-nayak sangeetha-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aratidgr8 aratidgr8 merged commit 31bf53d into trunk Jul 10, 2024
3 of 5 checks passed
@aratidgr8 aratidgr8 deleted the press0-1272 branch July 10, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants