Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Press0 1724 #9

Merged
merged 16 commits into from
Oct 8, 2024
Merged

Press0 1724 #9

merged 16 commits into from
Oct 8, 2024

Conversation

ramyakrishnai
Copy link
Collaborator

@ramyakrishnai ramyakrishnai commented Oct 7, 2024

Proposed changes

Jira: https://jira.newfold.com/browse/PRESS0-1724

  • My plugins && tools should be shown only if the entitlements are present, The button status changes as Install , Activate && learn more depending on the status of the plugin.
  • Adding data-nfd-installer-plugin-slug && data-nfd-installer-plugin-provider to trigger the module from PLS for installing the Plugins

Screenshots

Screenshot 2024-10-07 at 7 40 28 PM Screenshot 2024-10-07 at 7 41 18 PM

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@ramyakrishnai ramyakrishnai added the WIP Work in Progress label Oct 7, 2024
@ramyakrishnai ramyakrishnai requested review from circlecube and aratidgr8 and removed request for circlecube October 7, 2024 13:49
circlecube
circlecube previously approved these changes Oct 8, 2024
@circlecube circlecube merged commit 0d151aa into main Oct 8, 2024
3 of 4 checks passed
@circlecube circlecube deleted the PRESS0-1724 branch October 8, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants