feat: [#188079116] Show the License Status Check in Renewal Events #8551
Conversation
cbrunefearless
changed the title
cbrunefearless
force-pushed
the
cbrune/renewalEvents
branch
from
cefad8b to
8ce2f88
Compare
| urlSlug: health-care-services-firm-renewal | ||
| renewalEventDisplayName: Health Care Service Firm Renewal Deadline | ||
| expirationEventDisplayName: Health Care Service Firm Expiration | ||
| filename: health-care-services-firm-renewal |
There was a problem hiding this comment.
Boulder: the goal of this ticket is to add the license status component to the [licenseUrlSlug] page. This page renders the content living within content/src/licenses. The user is able to access the calendar license page by clicking the renewal/expiration link on the filings calendar. Alot of the existing functionality you added can be removed because it's already existing (i.e. mgmt/search, loading files, etc)
There was a problem hiding this comment.
One approach is to add the existing component to the [licenseUrlSlug] page and create tests to validate the data renders. All the other logic is not necessary because it's working. You may want to refactor the content/src/licenses to something like content/src/licenseCalendarEvents so it's more clear.
jphechter
changed the title
|
Appreciate the effort on this ahead of your trip. I think in working quickly we might have missed some of the overall goals of the ticket. |
| ); | ||
|
|
||
| expect(applicationCheckListItems).toBeInTheDocument(); | ||
| fireEvent.click(applicationCheckListItems); |
There was a problem hiding this comment.
[sand] Hey just a heads up, we should probably be using userEvent here since it more realistically simulates user interactions per the documentation. I believe fireEvent is recommended to be used as a last resort when an event is not covered by userEvent.
Description
User Story
As a Business.NJ.gov user, that has validated my license, I want to also see my status for my renewal calendar events
AC
Given my license status has been checked
when viewing my calendar renewal event
then the new design with my license status and renewal instructions are rendered on the page
Dev Note: At the very top on the page, there should be a field that contains the following default text, it can be overridden by content - "You can renew your license 60 days before it expires and up to 30 days after expiration. If you fail to renew your license at this point, your license will be suspended and you won't be able to provide your licensed services."
Also, pull in Jaime, we need to clean up the CMS Preview. - Done
Ticket
This pull request resolves #188079116.
Approach
Steps to Test
Notes
Code author checklist
userData(includingprofileData,formationDataetc), then I added a new migration filecmsCollections.ts(see CMS Additions in Engineering Reference/FAQ on the engineering documentation site).envvalues in both.env-templateand in Bitwarden