chore: [#188558362] upgrade serverless to v4

[aadedejifearless]

Description

This PR upgrades the Navigator repository to Serverless Framework V4, addressing the end-of-life (EOL) and end-of-support status of V3. The upgrade ensures compatibility with the latest features, resolves deprecations and enhances security by aligning with updated best practices in V4.

Ticket

This pull request resolves #188558362.

Approach

The approach taken in this PR involved updating package dependencies to ensure compatibility with Serverless Framework v4, as the framework has reached its end of life and support for v3. Environment variable references were adjusted to include the SERVERLESS_ACCESS_KEY, which triggers the serverless login process, and a deployment bucket configuration was added for better stage-specific management. Additionally, the need for webpack has been eliminated since Serverless Framework v4 introduces native ESBuild support, simplifying the build process and reducing dependency complexity. This also enhances security and maintainability by removing outdated tools. The updates ensure that the project aligns with the latest Serverless Framework standards and best practices.

Steps to Test

1. Push Changes to Test Branch: The changes were pushed to the test branch to ensure that the updates were applied to the appropriate environment.

2. Validate Deployment: After pushing the changes, I validated the deployment by checking that the serverless-state.json file reflects the expected version 4 format, confirming that the migration to Serverless V4 was successful.

Notes

Code author checklist

• I have rebased this branch from the latest main branch
• I have performed a self-review of my code
• I have created and/or updated relevant documentation on the engineering documentation website
• I have not used any relative imports
• I have pruned any instances of unused code
• I have not added any markdown to labels, titles and button text in config
• If I added/updated any values in userData (including profileData, formationData etc), then I added a new migration file
• I have checked for and removed instances of unused config from CMS
• If I added any new collections to the CMS config, then I updated the search tool and cmsCollections.ts (see CMS Additions in Engineering Reference/FAQ on the engineering documentation site)
• I have updated relevant .env values in both .env-template and in Bitwarden

[seidior]

Super impressed you were able to implement this in such a short amount of time. Well done, Ade!

[seidior]

Also, do we need to update our .env-template with a field for the Serverless Access Key?

[aadedejifearless]

Also, do we need to update our .env-template with a field for the Serverless Access Key?

For this piece we only added the field for the the deployment key. since we no longer need to add the key to the .env file based on Case's comment.

[jphechter]

Do we actually need this in our .env file? I think the answer is no, but if we need it then we should add this value to api/.env in Bitwarden.

[aadedejifearless]

Yh updated that. We have a fall back as default-bucket which would avoid the

[@businessnjgovnavigator/api]: Packaging "businessnjgov-api" for stage "local" (*********)
[@businessnjgovnavigator/api]: 
[@businessnjgovnavigator/api]: ✖ Access denied when storing the parameter "/serverless-framework/deployment/s3-bucket". Please check your permissions and try again. You have the following op
at 'provider.deploymentBucket': must NOT have fewer than 3 characters``` error

[jphechter]

2 brief comments

The only other thing I'd like to validate is that we've deployed this successfully to the testing site. If it's working there, then I'm very excited to see this go live.

[aadedejifearless]

2 brief comments

The only other thing I'd like to validate is that we've deployed this successfully to the testing site. If it's working there, then I'm very excited to see this go live.

Yh this was also deployed to testing and there were no issue.