Added functionality to activate keeping the mac awake when connected to AC power #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newmarcel
requested changes
May 7, 2022
| - (void)checkPowerSource | ||
| { | ||
| CFTypeRef powerSourceInfo = IOPSCopyPowerSourcesInfo(); | ||
| CFArrayRef powerSources = IOPSCopyPowerSourcesList(powerSourceInfo); |
There was a problem hiding this comment.
Implementation-wise this is certainly possible to solve it like that.
I would prefer to not add IOPowerSources code directly here in KYAAppController. This would probably be a better fit for KYABatteryMonitor. There is some pre-existing IOPowerSources code already, that could be extended, e.g. by adding concrete notifications for this connect/disconnect scenario.
|
Closed because of inactivity. Please open it again if development resumes, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am happy to get other ideas on how to detect power source changes.
In any case, it implements #104