Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NR-352205] CFN template validate metrics with logging integration #22

Merged
merged 15 commits into from
Feb 25, 2025
Merged

[NR-352205] CFN template validate metrics with logging integration #22

merged 15 commits into from
Feb 25, 2025

Conversation

ahegdeNR
Copy link
Contributor

@ahegdeNR ahegdeNR commented Feb 17, 2025 •
edited
Loading

As part of this pr:

  1. Deployed lambda+firehose+metrics stacks
  2. Validated if stacks got created successfully
  3. Delete stacks on completion
  4. Stacks will run parallely with modification in metrics stream name (stream name needs to be unique per account)

@ahegdeNR ahegdeNR requested review from maya-jha and hrai-nr February 17, 2025 08:57
@ahegdeNR ahegdeNR self-assigned this Feb 17, 2025
@ahegdeNR ahegdeNR changed the base branch from main to develop February 17, 2025 08:57
@hrai-nr
Copy link
Contributor

hrai-nr commented Feb 17, 2025

As part of this pr:

  1. Deployed lambda+firehose+metrics stacks
  2. Validated if stacks got created successfully
  3. Delete stacks on completion
  4. Stacks won't run parallely as every aws account will have only one metrics stack deployed at once

Code is looking good,
While I agree that metrics stack can't be deployed more than once and you are running it sequentially, but it is taking around 1 hour to finish.
There is a hack to run multiple metrics stack at one go, you just add some random variable to the default names similar to image below:
image

Reference Slack thread:
https://newrelic.slack.com/archives/C07AFGCA2D9/p1734596687792049?thread_ts=1734545429.490429&cid=C07AFGCA2D9

hrai-nr
hrai-nr requested changes Feb 18, 2025
View reviewed changes
hrai-nr
hrai-nr approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@hrai-nr hrai-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good to me

maya-jha
maya-jha reviewed Feb 25, 2025
View reviewed changes
e2e-tests/common-scripts/stack-scripts.sh
NewRelicLicenseKey="$NEW_RELIC_LICENSE_KEY" \
NewRelicRegion="$NEW_RELIC_REGION" \
MetricCollectionMode="$METRIC_COLLECTION_MODE" \
FirehoseStreamName="$METRIC_STREAM_NAME-third" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this how you were able to override the stream name and could run tests in parallel?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maya-jha yes that's right

@maya-jha maya-jha self-requested a review February 25, 2025 09:10
@ahegdeNR ahegdeNR merged commit 9396bb1 into develop Feb 25, 2025
65 checks passed
@ahegdeNR ahegdeNR deleted the NR-352205-e2e-tests-metrics branch February 25, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maya-jha maya-jha maya-jha approved these changes

@hrai-nr hrai-nr hrai-nr approved these changes

Assignees

@ahegdeNR ahegdeNR

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahegdeNR @hrai-nr @maya-jha