fix: Always return a string for custom stringify method

newrelic · Oct 2, 2024 · d6fe8f9 · d6fe8f9
1 parent 1306012
commit d6fe8f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/common/util/stringify.js b/src/common/util/stringify.js
@@ -31,7 +31,7 @@ const getCircularReplacer = () => {
  */
 export function stringify (val) {
   try {
-    return JSON.stringify(val, getCircularReplacer())
+    return JSON.stringify(val, getCircularReplacer()) ?? ''
   } catch (e) {
     try {
       ee.emit('internal-error', [e])

diff --git a/tests/unit/common/util/stringify.test.js b/tests/unit/common/util/stringify.test.js
@@ -19,10 +19,12 @@ test('should utilize JSON.stringify to serialize input data', () => {
 test.each([
   ['array', [0, 1, 'asdf', undefined, null, 'weee'], '[0,1,"asdf",null,null,"weee"]'],
   ['object', { a: 123, c: 'b', f: 'asdf', u: undefined, n: null }, '{"a":123,"c":"b","f":"asdf","n":null}'],
-  ['undefined', undefined, undefined],
+  ['undefined', undefined, ''],
   ['null', null, 'null'],
   ['number', 123, '123'],
-  ['function', function F () {}, undefined],
+  ['string', '0', '"0"'],
+  ['symbol', Symbol('foo'), ''],
+  ['function', function F () {}, ''],
   ['object w/ prototype', (() => { function F () {}; F.prototype = { a: 123 }; const obj = new F(); obj.other = 222; return obj })(), '{"other":222}'],
   ['nested json', { stringified: stringify({ a: 123, c: 'b', f: 'asdf', u: undefined, n: null }) }, '{"stringified":"{\\"a\\":123,\\"c\\":\\"b\\",\\"f\\":\\"asdf\\",\\"n\\":null}"}']
 ])('should serialize input %s properly', (_, input, expected) => {