Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add SM with data size for aborts #1063

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Jun 7, 2024

for evaluation of SR payload splitting effort

Overview

Related Issue(s)

Testing

Copy link

github-actions bot commented Jun 7, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 33.86 kB / 11.85 kB (gzip) 33.86 kB / 11.85 kB (gzip) 0% / 0% (gzip)
lite async-chunk 49.95 kB / 16.13 kB (gzip) 49.95 kB / 16.13 kB (gzip) 0% / 0% (gzip)
pro loader 54.53 kB / 18.49 kB (gzip) 54.53 kB / 18.49 kB (gzip) 0% / 0.01% (gzip)
pro async-chunk 94.98 kB / 28.63 kB (gzip) 95.02 kB / 28.64 kB (gzip) 0.05% / 0.03% (gzip)
spa loader 62.69 kB / 20.98 kB (gzip) 62.69 kB / 20.98 kB (gzip) 0% / 0% (gzip)
spa async-chunk 110.24 kB / 33.06 kB (gzip) 110.29 kB / 33.08 kB (gzip) 0.04% / 0.05% (gzip)
lite-polyfills loader 127.83 kB / 41.14 kB (gzip) 127.83 kB / 41.14 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 64.69 kB / 18.46 kB (gzip) 64.69 kB / 18.46 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 149.97 kB / 47.25 kB (gzip) 149.97 kB / 47.25 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 117.29 kB / 30.96 kB (gzip) 117.29 kB / 30.96 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 158.22 kB / 49.42 kB (gzip) 158.22 kB / 49.42 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 134.29 kB / 35.59 kB (gzip) 134.29 kB / 35.59 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.56%. Comparing base (c573e33) to head (108e216).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1063   +/-   ##
=======================================
  Coverage   87.56%   87.56%           
=======================================
  Files         162      162           
  Lines        7180     7180           
  Branches     1406     1406           
=======================================
  Hits         6287     6287           
  Misses        778      778           
  Partials      115      115           
Flag Coverage Δ
unit-tests 76.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah changed the title chore: add SM with data size for aborts, for evaluation of SR payload splitting effort chore: add SM with data size for aborts Jun 12, 2024
@metal-messiah metal-messiah merged commit ef99a25 into main Jun 12, 2024
22 of 23 checks passed
@metal-messiah metal-messiah deleted the sr-snapshot-size-sm branch June 12, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants