Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dedup pre-load ajax requests #1081

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: dedup pre-load ajax requests #1081

merged 2 commits into from
Jun 24, 2024

Conversation

patrickhousley
Copy link
Contributor

Fixing an issue where ajax requests made prior to the page load event would be reported as part of the SPA data and as standard ajax events.

Overview

Changed the load order of the features so that the SPA feature loaded before the ajax feature. This way, the SPA feature has a chance to decorate the ajax data with an interaction ID before the ajax feature processes it.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-274140

Testing

Copy link

github-actions bot commented Jun 24, 2024

Static Badge

Last ran on June 24, 2024 16:18:11 CDT
Checking merge of (528f5e1) into main (f5b9bc9)

Copy link

github-actions bot commented Jun 24, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 34.69 kB / 12.12 kB (gzip) 34.69 kB / 12.12 kB (gzip) 0% / 0.01% (gzip)
lite async-chunk 50.03 kB / 16.16 kB (gzip) 50.03 kB / 16.16 kB (gzip) 0% / 0% (gzip)
pro loader 55.25 kB / 18.71 kB (gzip) 55.25 kB / 18.71 kB (gzip) 0.01% / 0.01% (gzip)
pro async-chunk 95.93 kB / 28.81 kB (gzip) 95.93 kB / 28.81 kB (gzip) 0% / 0% (gzip)
spa loader 63.19 kB / 21.15 kB (gzip) 63.19 kB / 21.15 kB (gzip) 0.01% / 0.01% (gzip)
spa async-chunk 111.04 kB / 33.18 kB (gzip) 111.04 kB / 33.18 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 128.4 kB / 41.45 kB (gzip) 128.4 kB / 41.45 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 63.93 kB / 18.43 kB (gzip) 63.93 kB / 18.43 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 150.59 kB / 47.69 kB (gzip) 150.59 kB / 47.69 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 116.08 kB / 31.03 kB (gzip) 116.08 kB / 31.03 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 158.78 kB / 49.85 kB (gzip) 158.79 kB / 49.85 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 133.04 kB / 35.73 kB (gzip) 133.04 kB / 35.73 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (f5b9bc9) to head (528f5e1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
- Coverage   87.68%   87.67%   -0.02%     
==========================================
  Files         162      162              
  Lines        7246     7246              
  Branches     1419     1419              
==========================================
- Hits         6354     6353       -1     
- Misses        776      777       +1     
  Partials      116      116              
Flag Coverage Δ
integration-tests 91.57% <100.00%> (-0.03%) ⬇️
unit-tests 76.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickhousley patrickhousley merged commit 9f95b33 into main Jun 24, 2024
34 of 36 checks passed
@patrickhousley patrickhousley deleted the dedup-ajax branch June 24, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants