Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Removing long task #1153

Merged
merged 2 commits into from
Sep 16, 2024
Merged

feat: Removing long task #1153

merged 2 commits into from
Sep 16, 2024

Conversation

cwli24
Copy link
Contributor

@cwli24 cwli24 commented Aug 16, 2024

Previously, an agent configuration turned on reporting of long tasks that took over 50ms. This functionality is being shelved effective this agent version. The configuration will no longer do anything.

Overview

Long task is being sunset at this time.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-261378

Testing

Copy link

github-actions bot commented Aug 16, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.69 kB / 11.1 kB (gzip) 30.68 kB / 11.1 kB (gzip) -0.04% / -0.05% (gzip)
lite async-chunk 50.27 kB / 16.33 kB (gzip) 49.41 kB / 16.14 kB (gzip) -1.71% / -1.19% (gzip)
pro loader 51.33 kB / 17.72 kB (gzip) 51.32 kB / 17.71 kB (gzip) -0.03% / -0.02% (gzip)
pro async-chunk 96.81 kB / 29.3 kB (gzip) 95.95 kB / 29.08 kB (gzip) -0.89% / -0.73% (gzip)
spa loader 58.98 kB / 20.1 kB (gzip) 58.97 kB / 20.09 kB (gzip) -0.02% / -0.05% (gzip)
spa async-chunk 111.87 kB / 33.64 kB (gzip) 111.01 kB / 33.43 kB (gzip) -0.77% / -0.62% (gzip)

Copy link

github-actions bot commented Aug 16, 2024

Static Badge

Last ran on August 16, 2024 14:03:06 CDT
Checking merge of (c246038) into main (fbc6f9d)

Copy link
Member

@metal-messiah metal-messiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently blocked by product until feedback is received

@cwli24 cwli24 enabled auto-merge (squash) September 3, 2024 22:42
@cwli24 cwli24 merged commit 304e395 into main Sep 16, 2024
16 checks passed
@cwli24 cwli24 deleted the remove-longtask branch September 16, 2024 17:41
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.29%. Comparing base (b12131c) to head (079b696).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1153      +/-   ##
==========================================
- Coverage   88.45%   88.29%   -0.16%     
==========================================
  Files         165      172       +7     
  Lines        7249     7384     +135     
  Branches     1484     1489       +5     
==========================================
+ Hits         6412     6520     +108     
- Misses        716      732      +16     
- Partials      121      132      +11     
Flag Coverage Δ
unit-tests 78.78% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants