Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update webview app identifier #1185

Merged
merged 2 commits into from
Sep 17, 2024
Merged

chore: update webview app identifier #1185

merged 2 commits into from
Sep 17, 2024

Conversation

metal-messiah
Copy link
Member

Please add a one-paragraph summary here, suitable for a release notes description. This will help with documentation.

Overview

Related Issue(s)

Testing

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.68 kB / 11.1 kB (gzip) 30.68 kB / 11.1 kB (gzip) 0% / 0% (gzip)
lite async-chunk 49.42 kB / 16.14 kB (gzip) 49.42 kB / 16.14 kB (gzip) 0% / 0% (gzip)
pro loader 51.32 kB / 17.72 kB (gzip) 51.32 kB / 17.72 kB (gzip) 0% / 0% (gzip)
pro async-chunk 95.96 kB / 29.09 kB (gzip) 95.96 kB / 29.09 kB (gzip) 0% / 0% (gzip)
spa loader 58.97 kB / 20.09 kB (gzip) 58.97 kB / 20.09 kB (gzip) 0% / 0% (gzip)
spa async-chunk 111.02 kB / 33.43 kB (gzip) 111.02 kB / 33.43 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (e689a78) to head (086a71c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1185      +/-   ##
==========================================
+ Coverage   88.39%   88.48%   +0.09%     
==========================================
  Files         164      164              
  Lines        7228     7228              
  Branches     1479     1479              
==========================================
+ Hits         6389     6396       +7     
+ Misses        718      711       -7     
  Partials      121      121              
Flag Coverage Δ
unit-tests 78.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cwli24 cwli24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this app? I don't see it (which means the team bot account won't see it)

@cwli24 cwli24 merged commit cf9edc4 into main Sep 17, 2024
19 checks passed
@cwli24 cwli24 deleted the update-android-webview branch September 17, 2024 18:29
jspivack pushed a commit to jspivack/newrelic-browser-agent that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants