Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: automate uploading webview assets to lt #1188

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

metal-messiah
Copy link
Member

automate uploading webview assets to lt

Overview

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-314477

Testing

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.68 kB / 11.1 kB (gzip) 30.68 kB / 11.1 kB (gzip) 0% / 0% (gzip)
lite async-chunk 49.42 kB / 16.14 kB (gzip) 49.42 kB / 16.14 kB (gzip) 0% / 0% (gzip)
pro loader 51.32 kB / 17.72 kB (gzip) 51.32 kB / 17.72 kB (gzip) 0% / 0% (gzip)
pro async-chunk 95.96 kB / 29.09 kB (gzip) 95.96 kB / 29.09 kB (gzip) 0% / 0% (gzip)
spa loader 58.97 kB / 20.09 kB (gzip) 58.97 kB / 20.09 kB (gzip) 0% / 0% (gzip)
spa async-chunk 111.02 kB / 33.43 kB (gzip) 111.02 kB / 33.43 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (8da5a0b) to head (9118926).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1188   +/-   ##
=======================================
  Coverage   88.39%   88.39%           
=======================================
  Files         164      164           
  Lines        7228     7228           
  Branches     1479     1479           
=======================================
  Hits         6389     6389           
  Misses        718      718           
  Partials      121      121           
Flag Coverage Δ
unit-tests 78.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ptang-nr ptang-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with how webview assets are used exactly by our tests yet but code-wise seems to look ok. Voting to approve.

@metal-messiah metal-messiah merged commit 3ece5e5 into main Oct 7, 2024
18 checks passed
@metal-messiah metal-messiah deleted the automate-webview-upload branch October 7, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants