Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Marks and measures #1189

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: Marks and measures #1189

wants to merge 16 commits into from

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Sep 17, 2024

Add detection for marks and measures which captures data as a BrowserPerformance event. This feature is being shipped in an experimental state and is off by default. To opt in to using this feature, it can be turned on by setting the config value init.performance.capture_marks = true or init.performance.capture_measures = true in Copy/Paste or NPM installations.

Overview

  • This PR is branched from the UserActions PR, and that PR should be reviewed and merged first.

Related Issue(s)

NR-308305
NR-308314
NR-308319

Testing

Component and E2E tests have been added

Copy link

github-actions bot commented Sep 17, 2024

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.48 kB / 11.03 kB (gzip) 30.53 kB / 11.05 kB (gzip) 0.17% / 0.2% (gzip)
lite async-chunk 51.57 kB / 16.74 kB (gzip) 51.57 kB / 16.74 kB (gzip) 0% / 0% (gzip)
pro loader 51.5 kB / 17.79 kB (gzip) 51.61 kB / 17.84 kB (gzip) 0.21% / 0.28% (gzip)
pro async-chunk 99.71 kB / 30.47 kB (gzip) 100.23 kB / 30.61 kB (gzip) 0.51% / 0.45% (gzip)
spa loader 59.15 kB / 20.16 kB (gzip) 59.26 kB / 20.2 kB (gzip) 0.19% / 0.2% (gzip)
spa async-chunk 114.78 kB / 34.82 kB (gzip) 115.29 kB / 34.95 kB (gzip) 0.45% / 0.38% (gzip)

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.53%. Comparing base (033f97a) to head (df12fb3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1189      +/-   ##
==========================================
- Coverage   88.60%   88.53%   -0.07%     
==========================================
  Files         168      168              
  Lines        7334     7351      +17     
  Branches     1501     1505       +4     
==========================================
+ Hits         6498     6508      +10     
- Misses        713      718       +5     
- Partials      123      125       +2     
Flag Coverage Δ
integration-tests 91.84% <100.00%> (+0.01%) ⬆️
unit-tests 79.03% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metal-messiah metal-messiah marked this pull request as ready for review October 3, 2024 16:55
Copy link

github-actions bot commented Oct 3, 2024

Static Badge

Last ran on October 04, 2024 09:27:12 CDT
Checking merge of (df12fb3) into main (033f97a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants