-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Upgrade to web-vitals v4 #1193
Conversation
Old `event*` attrs are preserved to ease v3 to v4 transition for customers/any internal refs. The only exception is `eventType`, which is replaced due to being a reserved keyword in NRDB.
Note: interactionTargetElement, processedEventEntries, and longAnimationFrameEntries are excluded.
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
==========================================
+ Coverage 88.38% 88.43% +0.05%
==========================================
Files 164 164
Lines 7229 7229
Branches 1478 1478
==========================================
+ Hits 6389 6393 +4
+ Misses 722 717 -5
- Partials 118 119 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work
Co-authored-by: Chunwai Li <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all tests passing 👍 nicely done
Upgrade to web-vitals v4. For more info, please see https://github.com/GoogleChrome/web-vitals/blob/main/docs/upgrading-to-v4.md.
Overview
In this PR, we are upgrading to current latest web-vitals lib (v4.2.3) following the web-vitals upgrade doc.
Notable changes:
INP
eventType
is renamed tointeractionType
to avoid keyword conflict within NRinteraction*
equivalents for otherevent*
attrs in useevent*
attrs are preserved for backwards compatibility to be EOL'd at a later timeLCP
resourceLoadTime
as replacement forresourceLoadDuration
resourceLoadDuration
is preserved for backwards compatibility to be EOL'd at a later timeRelated Issue(s)
https://new-relic.atlassian.net/browse/NR-296095
Testing
Relevant web-vital unit tests + PVT integration tests