Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve reliability of customMasker #1197

Merged
merged 1 commit into from
Sep 24, 2024
Merged

fix: Improve reliability of customMasker #1197

merged 1 commit into from
Sep 24, 2024

Conversation

metal-messiah
Copy link
Member

@metal-messiah metal-messiah commented Sep 23, 2024

The customMasker method of the Session Replay feature has been fixed to be more reliable with DOM elements that do not fit web-standards, as to not throw errors when processing. Initial Replay harvests will now be gated until a valid snapshot is taken.

Overview

This PR has been named the way it has to encapsulate SR bug fix changes that span across this PR and some that were rolled into #1190. It has been named this way to aid with the release notes.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-314446

Testing

Tests should continue to pass

Copy link

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 30.66 kB / 11.09 kB (gzip) 30.66 kB / 11.09 kB (gzip) 0% / 0% (gzip)
lite async-chunk 51.5 kB / 16.72 kB (gzip) 51.5 kB / 16.72 kB (gzip) 0% / 0% (gzip)
pro loader 51.3 kB / 17.71 kB (gzip) 51.3 kB / 17.71 kB (gzip) 0% / -0.01% (gzip)
pro async-chunk 97.95 kB / 29.64 kB (gzip) 97.98 kB / 29.65 kB (gzip) 0.03% / 0.03% (gzip)
spa loader 58.95 kB / 20.09 kB (gzip) 58.95 kB / 20.09 kB (gzip) 0% / 0% (gzip)
spa async-chunk 113.01 kB / 34 kB (gzip) 113.04 kB / 34.01 kB (gzip) 0.03% / 0.03% (gzip)

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.31%. Comparing base (81349b8) to head (b0bdece).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1197      +/-   ##
==========================================
- Coverage   88.37%   88.31%   -0.07%     
==========================================
  Files         164      164              
  Lines        7228     7231       +3     
  Branches     1478     1478              
==========================================
- Hits         6388     6386       -2     
- Misses        722      726       +4     
- Partials      118      119       +1     
Flag Coverage Δ
integration-tests 91.61% <100.00%> (-0.16%) ⬇️
unit-tests 78.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cwli24
Copy link
Contributor

cwli24 commented Sep 24, 2024

The release notes description should inform customers the behavioral change this introduces.

Copy link

github-actions bot commented Sep 24, 2024

Static Badge

Last ran on September 24, 2024 11:44:12 CDT
Checking merge of (b0bdece) into main (81349b8)

@metal-messiah metal-messiah merged commit 9f2ef1f into main Sep 24, 2024
33 of 36 checks passed
@metal-messiah metal-messiah deleted the custom-masker branch September 24, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants