-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add page url to Session Replay and Session Trace payloads #1203
Conversation
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1203 +/- ##
=======================================
Coverage 88.60% 88.60%
=======================================
Files 168 168
Lines 7334 7334
Branches 1501 1501
=======================================
Hits 6498 6498
Misses 713 713
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Origin url set initially at runtime is fixed and could become inaccurate for soft navigation (aka. SPA) usage scenarios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this has a passing test run i think this is g2g
To aid with troubleshooting Session Replay and Session Trace, page url will be included in the respective payload's query string under
attributes.currentUrl
.Overview
In this PR, we are adding the page URL to the query string of the corresponding Session Replay and Session Trace payloads under
attributes.pageUrl
. The page URL will be added last, so if the total payload size exceeds current limit (5000), then truncation may occur.Related Issue(s)
https://new-relic.atlassian.net/browse/NR-268394
Testing
Session Replay
Session Trace