Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix dry run automation #829

Merged
merged 1 commit into from
Dec 1, 2023
Merged

chore: fix dry run automation #829

merged 1 commit into from
Dec 1, 2023

Conversation

patrickhousley
Copy link
Contributor

Please add a one-paragraph summary here, suitable for a release notes description. This will help with documentation.

Overview

Fixes the issue with the dry run flag not working and an issue with the internal release script not using the correct parameters based on selected environment.

Related Issue(s)

https://new-relic.atlassian.net/browse/NR-185891

Testing

Copy link

github-actions bot commented Dec 1, 2023

Asset Size Report

Merging this pull request will result in the following asset size changes:

Agent Asset Previous Size New Size Diff
lite loader 31.05 kB / 10.54 kB (gzip) 31.05 kB / 10.54 kB (gzip) 0% / 0% (gzip)
lite async-chunk 45.58 kB / 15.05 kB (gzip) 45.58 kB / 15.05 kB (gzip) 0% / 0% (gzip)
pro loader 48.45 kB / 15.96 kB (gzip) 48.45 kB / 15.96 kB (gzip) 0% / 0% (gzip)
pro async-chunk 74.48 kB / 23.75 kB (gzip) 74.48 kB / 23.75 kB (gzip) 0% / 0% (gzip)
spa loader 54.91 kB / 17.93 kB (gzip) 54.91 kB / 17.93 kB (gzip) 0% / 0% (gzip)
spa async-chunk 89.25 kB / 28.16 kB (gzip) 89.25 kB / 28.16 kB (gzip) 0% / 0% (gzip)
lite-polyfills loader 122.57 kB / 39.56 kB (gzip) 122.57 kB / 39.56 kB (gzip) 0% / 0% (gzip)
lite-polyfills async-chunk 57.97 kB / 17.25 kB (gzip) 57.97 kB / 17.25 kB (gzip) 0% / 0% (gzip)
pro-polyfills loader 142.09 kB / 45.45 kB (gzip) 142.09 kB / 45.45 kB (gzip) 0% / 0% (gzip)
pro-polyfills async-chunk 101.74 kB / 27.34 kB (gzip) 101.74 kB / 27.34 kB (gzip) 0% / 0% (gzip)
spa-polyfills loader 150.11 kB / 47.61 kB (gzip) 150.11 kB / 47.61 kB (gzip) 0% / 0% (gzip)
spa-polyfills async-chunk 117.31 kB / 31.93 kB (gzip) 117.31 kB / 31.93 kB (gzip) 0% / 0% (gzip)

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c98d29) 78.25% compared to head (5cf6a87) 78.25%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #829   +/-   ##
=======================================
  Coverage   78.25%   78.25%           
=======================================
  Files         142      142           
  Lines        6355     6355           
  Branches     1228     1228           
=======================================
  Hits         4973     4973           
  Misses       1175     1175           
  Partials      207      207           
Flag Coverage Δ
unit-tests 55.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@patrickhousley patrickhousley merged commit 7369581 into main Dec 1, 2023
16 checks passed
@patrickhousley patrickhousley deleted the fix-dry-run branch December 1, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants