-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow container linking for AWS ECS applications. #2683
Conversation
Leaving this in draft until APM Services can take a look at the data and confirm this is working for them. |
Testing has been completed and the changes are working as expected. I have set the spec change PR to ready for review and will be marking this one as ready once it gets some approvals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
3a4002e
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2683 +/- ##
==========================================
+ Coverage 81.17% 81.23% +0.06%
==========================================
Files 459 460 +1
Lines 29204 29229 +25
Branches 3223 3223
==========================================
+ Hits 23705 23745 +40
+ Misses 4708 4697 -11
+ Partials 791 787 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Closes #2658
Author Checklist
Reviewer Checklist