Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow container linking for AWS ECS applications. #2683

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

jaffinito
Copy link
Member

Description

  • Updates our utilization payload to match new version of the spec.
  • Changes the logic for where we put the docker id captured from AWS ECS
  • Expands unit tests for ECS

Closes #2658

Author Checklist

  • Unit tests, Integration tests, and Unbounded tests completed
  • Performance testing completed with satisfactory results (if required)

Reviewer Checklist

  • Perform code review
  • Pull request was adequately tested (new/existing tests, performance tests)

@jaffinito
Copy link
Member Author

Leaving this in draft until APM Services can take a look at the data and confirm this is working for them.

@jaffinito
Copy link
Member Author

Testing has been completed and the changes are working as expected. I have set the spec change PR to ready for review and will be marking this one as ready once it gets some approvals.

@jaffinito jaffinito marked this pull request as ready for review September 10, 2024 20:04
@jaffinito jaffinito requested a review from a team as a code owner September 10, 2024 20:04
tippmar-nr
tippmar-nr previously approved these changes Sep 10, 2024
Copy link
Member

@tippmar-nr tippmar-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

chynesNR
chynesNR previously approved these changes Sep 11, 2024
nrcventura
nrcventura previously approved these changes Sep 11, 2024
@jaffinito jaffinito changed the title chore: Update to latest utilization spec for AWS ECS. feat: Update to latest utilization spec for AWS ECS. Sep 17, 2024
@jaffinito jaffinito changed the title feat: Update to latest utilization spec for AWS ECS. feat: Allow container linking for AWS ECS applications. Sep 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (80cf9ef) to head (3a4002e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2683      +/-   ##
==========================================
+ Coverage   81.17%   81.23%   +0.06%     
==========================================
  Files         459      460       +1     
  Lines       29204    29229      +25     
  Branches     3223     3223              
==========================================
+ Hits        23705    23745      +40     
+ Misses       4708     4697      -11     
+ Partials      791      787       -4     
Flag Coverage Δ
Agent 82.26% <100.00%> (+0.07%) ⬆️
Profiler 72.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../NewRelic/Agent/Core/Utilization/EcsVendorModel.cs 100.00% <100.00%> (ø)
...gent/NewRelic/Agent/Core/Utilization/VendorInfo.cs 89.13% <100.00%> (+5.30%) ⬆️

... and 1 file with indirect coverage changes

@jaffinito jaffinito merged commit d55567f into main Sep 18, 2024
97 checks passed
@jaffinito jaffinito deleted the other/fargate-spec-update branch September 18, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update how ECS docker id are handled in the agent
5 participants