Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summary: Azure function support (preview) #2724

Merged
merged 56 commits into from
Sep 11, 2024
Merged

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Aug 30, 2024

feat: Preview support for instrumentation of "isolated" model Azure Functions. Instrumentation is disabled by default. Please reach out to your account team if you would like to try this new feature.

tippmar-nr and others added 30 commits August 13, 2024 11:51
chore: Update Profiler NuGet Package Reference to v10.28.0.40.

Co-authored-by: tippmar-nr <[email protected]>
jaffinito and others added 9 commits August 29, 2024 09:45
* Added a config setting to disabled azure function mode by default, added a few unit tests in areas where function mode detection is used

* Minor cleanup

* Refactor
* Unit tests and a bug fix or two

* profiler unit tests

* Unit test tweak

* cleanup

* formatting
* Profiler update to exclude func.exe

* chore: Update Profiler NuGet Package Reference to v10.29.0.54 (#2734)

chore: Update Profiler NuGet Package Reference to v10.29.0.54.

Co-authored-by: tippmar-nr <[email protected]>

* WIP

* profiler azure function detection rework

* Azure function integration tests functional but not complete

* Upate all_solutions workflow to install azure functions tools and test the azurefunction namespace

* another install attempt

* test only azure function namespace for now

* Tweaks for the integration tests workflow

* enable all namespaces for integration tests

* cleanup

* Profiler: Allow log level override in azure function mode via NEW_RELIC_AZURE_FUNCTION_LOG_LEVEL_OVERRIDE=1

* workflow tweak

* chore: Update Profiler NuGet Package Reference to v10.29.0.66 (#2738)

chore: Update Profiler NuGet Package Reference to v10.29.0.66.

Co-authored-by: tippmar-nr <[email protected]>

* integration test tw4eaks

* profiler unit test update

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Integration test updates, added net6.0 and net8.0 plus a test to verify behavior when azure function mode is disabled.

* Integration test rework to use different HttpTrigger invocation methods
Disable aspnetcore middleware wrapper in azure function mode, update integration tests
@tippmar-nr tippmar-nr changed the title **DRAFT** feat: Azure function support feat: Azure function support (preview) Sep 9, 2024
@tippmar-nr tippmar-nr changed the title feat: Azure function support (preview) summary: Azure function support (preview) Sep 9, 2024
@tippmar-nr tippmar-nr marked this pull request as ready for review September 10, 2024 15:23
@tippmar-nr tippmar-nr requested a review from a team as a code owner September 10, 2024 15:23
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.69231% with 16 lines in your changes missing coverage. Please review.

Project coverage is 81.17%. Comparing base (b12e4c1) to head (7ac4712).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../Agent/Core/Configuration/ReportedConfiguration.cs 11.11% 8 Missing ⚠️
...nt/NewRelic/Profiler/MethodRewriter/ISystemCalls.h 0.00% 7 Missing ⚠️
...nt/NewRelic/Profiler/Configuration/Configuration.h 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2724      +/-   ##
==========================================
+ Coverage   80.91%   81.17%   +0.25%     
==========================================
  Files         458      459       +1     
  Lines       29147    29204      +57     
  Branches     3209     3223      +14     
==========================================
+ Hits        23585    23707     +122     
+ Misses       4771     4707      -64     
+ Partials      791      790       -1     
Flag Coverage Δ
Agent 82.19% <91.75%> (+0.27%) ⬆️
Profiler 72.12% <75.75%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gent/Core/Attributes/AttributeDefinitionService.cs 95.64% <100.00%> (+0.07%) ⬆️
...wRelic/Agent/Core/Config/BootstrapConfiguration.cs 100.00% <100.00%> (ø)
...c/Agent/Core/Configuration/DefaultConfiguration.cs 89.90% <100.00%> (+0.30%) ⬆️
...nt/NewRelic/Agent/Core/Transactions/Transaction.cs 80.70% <100.00%> (+0.19%) ⬆️
.../NewRelic/Agent/Core/Utilities/ExtensionsLoader.cs 32.87% <ø> (+16.43%) ⬆️
...nt/Core/Utilization/AzureFunctionAppVendorModel.cs 100.00% <100.00%> (ø)
...gent/NewRelic/Agent/Core/Utilization/VendorInfo.cs 83.82% <100.00%> (+0.66%) ⬆️
src/Agent/NewRelic/Profiler/Logging/Logger.h 86.95% <ø> (ø)
...nt/NewRelic/Profiler/Configuration/Configuration.h 76.82% <96.15%> (+1.82%) ⬆️
...nt/NewRelic/Profiler/MethodRewriter/ISystemCalls.h 46.55% <0.00%> (-6.39%) ⬇️
... and 1 more

... and 2 files with indirect coverage changes

@tippmar-nr tippmar-nr merged commit d8a79e5 into main Sep 11, 2024
105 checks passed
@tippmar-nr tippmar-nr deleted the feature/azure-functions branch September 11, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants