Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove System.Net.Http reference on .NET Framework. Resolves #2750 #2751

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

chynesNR
Copy link
Member

@chynesNR chynesNR commented Sep 11, 2024

See #2750 for explanation.

BEGIN_COMMIT_OVERRIDE
fix: Prevent FileNotFoundException when handling connection issues while instrumenting .NET Framework apps. (#2750) (#2751)
END_COMMIT_OVERRIDE

@chynesNR chynesNR requested a review from a team as a code owner September 11, 2024 20:37
tippmar-nr
tippmar-nr previously approved these changes Sep 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.18%. Comparing base (32e54c1) to head (d63a954).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2751      +/-   ##
==========================================
+ Coverage   81.17%   81.18%   +0.01%     
==========================================
  Files         459      459              
  Lines       29204    29204              
  Branches     3223     3223              
==========================================
+ Hits        23705    23709       +4     
+ Misses       4708     4705       -3     
+ Partials      791      790       -1     
Flag Coverage Δ
Agent 82.20% <ø> (+0.01%) ⬆️
Profiler 72.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...elic/Agent/Core/DataTransport/ConnectionManager.cs 79.71% <ø> (ø)

... and 1 file with indirect coverage changes

@nr-ahemsath nr-ahemsath merged commit cebd287 into main Sep 12, 2024
96 checks passed
@nr-ahemsath nr-ahemsath deleted the chore/remove-system-net-http-ref branch September 12, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants