Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Force terminate helper processes still running at dispose time #2860

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

chynesNR
Copy link
Member

An intermittent integration test failure I've noticed: if a RemoteProcess is hung, we can still send it shutdown signals without getting an error back, so we never force it to close. Then when we make our final attempt to shut it down in Dispose, it throws because the test logger is no longer available.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.40%. Comparing base (2460527) to head (ecf0a03).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2860      +/-   ##
==========================================
- Coverage   81.45%   81.40%   -0.05%     
==========================================
  Files         464      464              
  Lines       29524    29524              
  Branches     3266     3266              
==========================================
- Hits        24048    24035      -13     
- Misses       4681     4695      +14     
+ Partials      795      794       -1     
Flag Coverage Δ
Agent 82.31% <ø> (-0.05%) ⬇️
Profiler 73.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@chynesNR chynesNR marked this pull request as ready for review October 30, 2024 16:02
@chynesNR chynesNR requested a review from a team as a code owner October 30, 2024 16:02
Copy link
Member

@tippmar-nr tippmar-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@chynesNR chynesNR merged commit 7f07c4d into main Oct 30, 2024
94 checks passed
@chynesNR chynesNR deleted the test/integration-test-stability-2 branch October 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants