ci: Dotty Fixes #2952
Merged
ci: Dotty Fixes #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed bug in creating new PR, probably related to OctoKit major version bump
jaffinito
previously approved these changes
Jan 15, 2025
chynesNR
previously approved these changes
Jan 15, 2025
jaffinito
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Dotty PR creation logic to commit the changes to the new branch before creating a PR. Not sure why this was necessary now, but I'm assuming it's related to the OctoKit major version bump that was applied recently.
Also added a config in
packageInfo.jsonto allow updates for specific TFMs to be ignored (case in point:NServiceBusv9 isn't supported onnet481but we still want to update thenet9.0reference.)