NR-359870 fix for the attribute validator crash #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and used anywhere it's needed
smalsam-newr
requested changes
Jan 22, 2025
|
I think this is okay use of static. |
… try to address concerns.
…'s it's own class
smalsam-newr
previously approved these changes
Jan 24, 2025
| @@ -71,6 +74,8 @@ - (instancetype) initWithAnalyticsController:(NRMAAnalytics*)analytics | |||
| self = [super init]; | |||
| if (self) { | |||
| analyticsParent = analytics; | |||
|
|
|||
| _attributeValidator = [[NRMAAttributeValidator alloc] init]; | |||
There was a problem hiding this comment.
If you pass something that conforms to the AttributeValidator protocol in as a parameter to this class, then you can replace it for testing.
There was a problem hiding this comment.
Made the change to move it to be passed in.
…ndled exception, so it can be replaced for testing
mbruin-NR
dismissed stale reviews from smalsam-newr and cdillard-NewRelic
via
a47828e
smalsam-newr
approved these changes
Jan 27, 2025
cdillard-NewRelic
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved the attribute validator to utils so it can be static and used anywhere it's needed