Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bootstrap server metric for kafka #1207

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

hmstepanek
Copy link
Contributor

Add bootstrap server metric for Kafka to connect MSK AWS entities.

Copy link

github-actions bot commented Sep 10, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 5.13s
✅ PYTHON black 8 0 0 1.1s
✅ PYTHON flake8 8 0 0.57s
✅ PYTHON isort 8 0 0 0.33s
✅ PYTHON pylint 8 0 3.79s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 10 lines in your changes missing coverage. Please review.

Project coverage is 81.21%. Comparing base (8094552) to head (98657e6).

Files with missing lines Patch % Lines
newrelic/hooks/messagebroker_confluentkafka.py 70.37% 4 Missing and 4 partials ⚠️
newrelic/hooks/messagebroker_kafkapython.py 71.42% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1207      +/-   ##
==========================================
- Coverage   81.48%   81.21%   -0.28%     
==========================================
  Files         197      197              
  Lines       21825    21859      +34     
  Branches     3817     3827      +10     
==========================================
- Hits        17785    17753      -32     
- Misses       2915     2975      +60     
- Partials     1125     1131       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hmstepanek hmstepanek marked this pull request as ready for review September 11, 2024 18:09
@hmstepanek hmstepanek requested a review from a team as a code owner September 11, 2024 18:09
TimPansino
TimPansino previously approved these changes Sep 17, 2024
@hmstepanek hmstepanek enabled auto-merge (squash) September 19, 2024 16:00
@hmstepanek hmstepanek merged commit 844558d into main Sep 19, 2024
50 of 52 checks passed
@hmstepanek hmstepanek deleted the add-aws-kafka-entity-metrics branch September 19, 2024 17:03
@mergify mergify bot removed the tests-failing label Sep 19, 2024
@hmstepanek hmstepanek added this to the v10.0.0 milestone Sep 20, 2024
TimPansino added a commit that referenced this pull request Sep 25, 2024
* Add env var for GC runtime metrics.

* [Mega-Linter] Apply linters fixes

* Remove falcon master tests for py37 (unsupported)

* Bump tests

* Fix Psycopg3 Api Incompatibilities (#1197)

* Fix DBAPI2 wrappers to allow additional kwargs to executemany

* Pass extra psycopg3 kwargs through executemany

* Rename arguments in psycopg3 wrappers to match upstream

* Add tests for psycopg3 returning param

---------

Co-authored-by: Uma Annamalai <[email protected]>

* Fix bugs

* Test w/ latest langchain

* Add support for new vectorstores

* Remove unreachable []

* Use replace instead of lstrip to strip dns://

lstrip strips all the characters from the begining of the string so strings that begin
in d, n, or s get the first character(s) stripped. Replace is actually what we want in
this case.

* Add dispatcher for uvicorn_worker

* Fix bedrock expected error

* Add metadata field to expected events

* Adjust location of expected pydantic error

* Langchain does not support python3.8

* Remove graphql master from tests

* Add support for kafka-python-ng

* Capture pymemcache,aiomcache,bmemcached host&port

* Add bootstrap server metric for kafka (#1207)

* Add bootstrap server metric

* [Mega-Linter] Apply linters fixes

---------

Co-authored-by: hmstepanek <[email protected]>

* Lint f-strings

* Fix Issues in PyMongo and Botocore Tests (#1218)

* Fix schema issues in botocore tests

* Update pymongo hooks for new module locations

* Remove unsupported py38 tornadomaster tests

* Updated matrix for urllib3 tests (#1216)

---------

Co-authored-by: Uma Annamalai <[email protected]>
Co-authored-by: umaannamalai <[email protected]>
Co-authored-by: Hannah Stepanek <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: hmstepanek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants