Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ECS container IDs. #1209

Merged
merged 7 commits into from
Oct 1, 2024
Merged

Add support for ECS container IDs. #1209

merged 7 commits into from
Oct 1, 2024

Conversation

umaannamalai
Copy link
Contributor

This PR adds a new ECS vendor to parse container IDs in ECS/ Fargate environments.

Copy link

github-actions bot commented Sep 11, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
❌ PYTHON bandit 2 1 5.37s
✅ PYTHON black 6 4 0 1.8s
❌ PYTHON flake8 6 4 0.58s
✅ PYTHON isort 6 6 0 0.21s
✅ PYTHON pylint 6 0 5.26s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.13%. Comparing base (c07d6f4) to head (0a475af).

Files with missing lines Patch % Lines
newrelic/common/utilization.py 90.00% 4 Missing ⚠️
newrelic/core/agent_protocol.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
- Coverage   81.13%   81.13%   -0.01%     
==========================================
  Files         197      197              
  Lines       21598    21643      +45     
  Branches     3775     3782       +7     
==========================================
+ Hits        17523    17559      +36     
- Misses       2937     2945       +8     
- Partials     1138     1139       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@TimPansino TimPansino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated in staging UI, service map links to the infra agent as expected.

@umaannamalai umaannamalai marked this pull request as ready for review October 1, 2024 02:02
@umaannamalai umaannamalai requested a review from a team as a code owner October 1, 2024 02:02
@umaannamalai umaannamalai merged commit 01bff2b into main Oct 1, 2024
51 of 53 checks passed
@umaannamalai umaannamalai deleted the ecs-docker-id branch October 1, 2024 02:02
@mergify mergify bot removed the tests-failing label Oct 1, 2024
@umaannamalai umaannamalai added this to the 10.1.0 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants