Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AI test failures & do not run graphqlmaster tests #1211

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

hmstepanek
Copy link
Contributor

@hmstepanek hmstepanek commented Sep 16, 2024

Overview

Fix the following AI test failures:

  • Bedrock changed the order of payload assertions in commit: boto/botocore@db41663 which resulted in the expected error being different due to the validator order change.
  • Langchain added metadata to Document interface so update expected events with this field.
  • pydantic ValidationError moved locations so adjust the path to the error in the tests.
  • Langchain doesn't list support for Python3.8 so do not test it on Python3.8.
  • Graphql main tests are failing so comment these out for now.

@hmstepanek hmstepanek marked this pull request as ready for review September 16, 2024 21:53
@hmstepanek hmstepanek requested a review from a team as a code owner September 16, 2024 21:53
Copy link

github-actions bot commented Sep 16, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 0 0 1.22s
✅ PYTHON flake8 3 0 0.51s
✅ PYTHON isort 3 0 0 0.22s
✅ PYTHON pylint 3 0 4.23s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (d642980) to head (7e19ad8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1211      +/-   ##
==========================================
+ Coverage   80.05%   81.59%   +1.54%     
==========================================
  Files         197      197              
  Lines       21803    21803              
  Branches     3807     3807              
==========================================
+ Hits        17454    17790     +336     
+ Misses       3239     2897     -342     
- Partials     1110     1116       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

umaannamalai
umaannamalai previously approved these changes Sep 17, 2024
Copy link
Contributor

@umaannamalai umaannamalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving - independent of LangChain test failures

@hmstepanek hmstepanek changed the title Fix bedrock expected error for malformed response test Fix AI test failures Sep 17, 2024
@hmstepanek
Copy link
Contributor Author

@umaannamalai Would you mind giving this another review? I've added a couple additional fixes for langchain and graphql tests.

@hmstepanek hmstepanek changed the title Fix AI test failures Fix AI test failures & comment out graphqlmaster tests Sep 17, 2024
@hmstepanek hmstepanek changed the title Fix AI test failures & comment out graphqlmaster tests Fix AI test failures & do not run graphqlmaster tests Sep 17, 2024
@hmstepanek hmstepanek merged commit b9f328c into main Sep 17, 2024
48 of 52 checks passed
@hmstepanek hmstepanek deleted the fix-botocore-error-test branch September 17, 2024 22:43
@mergify mergify bot removed the tests-failing label Sep 17, 2024
@hmstepanek hmstepanek added this to the v10.0.0 milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants