Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back onepane #2435

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Add back onepane #2435

merged 2 commits into from
Jun 6, 2024

Conversation

MichelLosier
Copy link
Contributor

Summary

Adds back onepane changes from reverted release
#2429

Original PR
#2361

This PR cherry-picks the merge commit a5d194eedaca999d591df8c6a09266e17ac25122

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

nr-mlosier and others added 2 commits June 6, 2024 11:01
Updates main to the revert of release 2024-05-09
feat: Added onepane-dashboards
Copy link

github-actions bot commented Jun 6, 2024

The PR checks have run and found the following warnings:

Warning Filepath
"guid" should not be used dashboards/onepane/onepane.json
"entityGuid" should not be used dashboards/onepane/onepane.json

Reference the Contributing Docs for Dashboards for more information.

@MichelLosier MichelLosier merged commit 727647e into release Jun 6, 2024
19 checks passed
@MichelLosier MichelLosier deleted the mlosier/add-back-onepane branch June 6, 2024 20:13
@MichelLosier MichelLosier mentioned this pull request Jun 6, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants