Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Traceloop Integration #2467

Merged
merged 5 commits into from
Jul 10, 2024
Merged

feat: Traceloop Integration #2467

merged 5 commits into from
Jul 10, 2024

Conversation

spathlavath
Copy link
Contributor

Summary

Ticket: https://new-relic.atlassian.net/browse/NR-284874
Description: Created Traceloop Integration

Pre merge checklist

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • Does the PR contain a screenshot for each of your dashboards?
  • Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Alerts

  • Did you check that your alerts actually work?

@spathlavath spathlavath requested a review from rahulbasu-nr as a code owner July 4, 2024 06:29
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

The PR checks have run and found the following warnings:

Warning Filepath
"permissions" field should not be used dashboards/traceloop/traceloop.json

Reference the Contributing Docs for Dashboards for more information.

@spathlavath spathlavath requested a review from sjyothi54 July 4, 2024 06:31
RamanaReddy8801
RamanaReddy8801 approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@RamanaReddy8801 RamanaReddy8801 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After the docs go live, it will be merged

@spathlavath spathlavath marked this pull request as draft July 4, 2024 07:01
@spathlavath spathlavath marked this pull request as ready for review July 10, 2024 03:49
pkudikyala
pkudikyala approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@pkudikyala pkudikyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkudikyala pkudikyala merged commit 269e82d into newrelic:release Jul 10, 2024
16 checks passed
@zstix zstix mentioned this pull request Jul 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkudikyala pkudikyala pkudikyala approved these changes

@RamanaReddy8801 RamanaReddy8801 RamanaReddy8801 approved these changes

@rahulbasu-nr rahulbasu-nr Awaiting requested review from rahulbasu-nr

@sjyothi54 sjyothi54 Awaiting requested review from sjyothi54

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spathlavath @CLAassistant @pkudikyala @RamanaReddy8801