Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated replication.master.slaves.Offset NRQL #2588

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

rossfromwork
Copy link
Contributor

@rossfromwork rossfromwork commented Oct 15, 2024

Corrected NRQL used for Replication byte offset widget.

Changed from average(replication.master.slaves.Offset) to average('replication.master.slaves.Offset')

Summary

A concise description of the changes being introduced. Please review the pre-merge checklist section to validate this pull request is ready for review and merge. If it is not ready, please mark the pull request as a draft.

The owners of this repo are not experts in the subject matter of the quickstarts. We review for the quickstart to be functional and for security risks. If you are seeking feedback on the content of the quickstart, please seek out a subject matter expert. If you are not an internal NR contributor, we can do our best to connect you with a content reviewer.

  • Did you check you NRQL syntax? - Does it work?
  • Did you include a Data source and Documentation reference?
  • Are all documentation links publicly accessible?
  • Did you check your descriptive content for voice and tone?
  • Did you check your descriptive content for spelling and grammar errors?
  • Did you review your content with a subject matter expert? (e.g. a Browser agent quickstart is reviewed with a member of the Browser Agent team)

Dashboards

  • [N/A] Does the PR contain a screenshot for each of your dashboards?
  • [N/A] Do your screenshots show data?
  • Has the sanitization script been run on each dashboard?

Corrected NRQL used for Replication byte offset widget. 

Changed from average(replication.master.slaves.Offset) to average('replication.master.slaves.Offset')
@CLAassistant
Copy link

CLAassistant commented Oct 15, 2024

CLA assistant check
All committers have signed the CLA.

@rossfromwork rossfromwork changed the base branch from main to release October 16, 2024 02:30
Copy link
Contributor

@sjyothi54 sjyothi54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nr-mlosier
Copy link
Contributor

Closing so we can re-open fresh against newrelic:release and make sure the FOSSA CLI check runs

@nr-mlosier nr-mlosier closed this Oct 17, 2024
@nr-mlosier nr-mlosier reopened this Oct 17, 2024
@nr-mlosier nr-mlosier merged commit 0186d82 into newrelic:release Oct 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants