Rails v7.1 driven 'rails' / 'rails_prepend' suite updates #2248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the multiverse 'rails' suite for Rails v7.1 compatibility
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
leverage before suite logic for Rails v7.1 hacks
remove experimental Hash monkeypatch hack
Introduce Rails Edge testing to the 'rails' multiverse suite, for Rubies 3.0 and above
The browser monitoring 'installed?' instance var has moved
move the `MyApp` Rails app out into its own `my_app.rb` file, and make sure it gets loaded before the Rails test helpers do. those helpers will expect an app to be in play by the time they are loaded.
fallwith
changed the title
rails < 7 - use 'select' rails = 7.0 - use 'pluck' rails >= 7.1 - use 'ids'
- start testing Rails Edge - stop testing amusing 'plucky' debugging
For the constants related to browser monitoring, include `BROWSER_MONITORING` in their names so that its more clear as to what they are used for.
kaylareopelle
previously approved these changes
Oct 10, 2023
- set an env var for CI workflows to denote CI workflow presence - use a common Envfile helper to unshift Rails Edge onto the list of gem versions to test against - update `active_record_pg`, `rails`, and `rails_prepend` to use the helper - do not touch `active_record` at this time
fix var naming typo
kaylareopelle
previously approved these changes
Oct 11, 2023
use 'unshift' to avoid confusion with Ruby module prepend behavior
tannalynn
reviewed
Oct 11, 2023
tannalynn
approved these changes
Oct 11, 2023
kaylareopelle
approved these changes
Oct 11, 2023
| def unshift_rails_edge(gem_version_array = []) | ||
| return if ci_for_pr? | ||
|
|
||
| # Unshift Rails Edge (representing the latest GitHub primary branch |
There was a problem hiding this comment.
Very helpful comment! Cool we get to test with the latest now
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the multiverse 'rails' suite (which also has content reused by the 'rails_prepend' suite) for Rails v7.1 compatibility
resolves #2243
resolves #2244