Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs test: ignore 2 new false positives #2281

Merged
merged 2 commits into from
Oct 23, 2023
Merged

URLs test: ignore 2 new false positives #2281

merged 2 commits into from
Oct 23, 2023

Conversation

fallwith
Copy link
Contributor

teach the URL tester to ignore 2 new patterns

  • Ignore Ethon wrappers class' dynamically interpolated URL
  • Ignore the sometimes unreachable HTTPX homepage

@fallwith
URLs test: ignore 2 new false positives
1a11341 
teach the URL tester to ignore 2 new patterns

- Ignore Ethon wrappers class' dynamically interpolated URL
- Ignore the sometimes unreachable HTTPX homepage
@fallwith
URL tests: re-enable skips
e439035 
re-enable the skips
@github-actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 94.2% 94%
Branch 85.81% 85%

@fallwith fallwith merged commit 5c760f2 into dev Oct 23, 2023
115 checks passed
@fallwith fallwith deleted the your_hat_says_M_so_you_are_M_but_who_am_i branch October 23, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@hannahramadan hannahramadan Awaiting requested review from hannahramadan hannahramadan is a code owner

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fallwith @kaylareopelle