add additional attributes for OTel compatibility #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 attributes have been added to datastore segments and 3 attributes have been added to external request segments for improved alignment with OTel specifications.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
fix closing tick
hannahramadan
previously approved these changes
Oct 23, 2023
tannalynn
previously approved these changes
Oct 23, 2023
PR #2284 added 3 new attributes that need to be included in the tests
fallwith
dismissed stale reviews from tannalynn and hannahramadan
via
62bcaec
kaylareopelle
requested changes
Oct 24, 2023
O Tel -> OTel Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
kaylareopelle
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 attributes have been added to datastore segments and 3 attributes have been added to external request segments for improved alignment with OTel specifications.
resolves #2190