Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid compiling gRPC with Ruby 3.3 #2326

Merged
merged 1 commit into from
Nov 20, 2023
Merged

avoid compiling gRPC with Ruby 3.3 #2326

merged 1 commit into from
Nov 20, 2023

Conversation

fallwith
Copy link
Contributor

for now, don't test gRPC with Ruby 3.3 to prevent CI issues

CI cron run: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/6911039829

@fallwith
avoid compiling gRPC with Ruby 3.3
0ff6e60 
for now, don't test gRPC with Ruby 3.3 to prevent CI issues
@github-actions GitHub Actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 94.23% 94%
Branch 82.78% 82%

kaylareopelle
kaylareopelle approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this.

@fallwith fallwith merged commit b260f13 into dev Nov 20, 2023
114 checks passed
@fallwith fallwith deleted the nogrpcfor33 branch November 20, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@hannahramadan hannahramadan Awaiting requested review from hannahramadan hannahramadan is a code owner

@tannalynn tannalynn Awaiting requested review from tannalynn tannalynn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fallwith @kaylareopelle