Test ActiveJob perform_all_later
#2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 9.3.0
Release 9.3.1
Release 9.4.0
Release 9.4.1
Release 9.4.2
Release 9.5.0
Release 9.6.0
SimpleCov Report
|
hannahramadan
requested review from
fallwith,
kaylareopelle and
tannalynn
as code owners
fallwith
previously approved these changes
Nov 22, 2023
| skip if Gem::Version.new(Rails::VERSION::STRING) < Gem::Version.new('7.1.0') | ||
|
|
||
| in_web_transaction do | ||
| ActiveJob.perform_all_later(MyJob.new) |
There was a problem hiding this comment.
The docs for this method make it sound like the method is intended for multiple jobs. Would you mind adding a test that looks at how the agent behaves when multiple jobs are given to perform_all_later?
There was a problem hiding this comment.
Great call out! Updated the test to include multiple jobs.
kaylareopelle
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for ActiveJob
perform_all_later, introduced in Rails 7.1.0.Closes #2222